Remove deserializing/reserializing toml from configure.py #137408
Conversation
|
Could not assign reviewer from: |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @clubby789 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
abylaw
force-pushed
the
simplify-configure
branch
from
b805a73 to
986d881
Compare
| for line in lines[i:]: | ||
| if line.startswith("["): | ||
| if section: | ||
| # Write out the previous section before starting a new one. | ||
| # | ||
| # Note that the `target` section is handled separately as we'll | ||
| # duplicate it per configured target, so there's a bit of special | ||
| # handling for that here. | ||
| if section_name.startswith("target"): |
There was a problem hiding this comment.
This only writes out a section when we encounter the next, which means the final section is never written (i.e. dist is dropped)
There was a problem hiding this comment.
Oops, you're totally right. Will fix.
|
Triage: comment is not addressed |
rustbot
added
S-waiting-on-author
|
Hi @abylaw, do you still want to work on this PR? |
Instead, creates the toml line by line without deserializing/deserializing and replacing the values.
#112445
r? jyn514