Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 20 rc 3 #137661

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Update to LLVM 20 rc 3 #137661

merged 1 commit into from
Mar 2, 2025

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Feb 26, 2025

Fixes a compiler-builtins miscompile (see rust-lang/compiler-builtins#760).

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2025
@rust-log-analyzer

This comment has been minimized.

@onur-ozkan
Copy link
Member

onur-ozkan commented Feb 26, 2025

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

https://github.com/rust-lang/rust/pull/137594/files#diff-e5255e85d66ab827c6eff26a377f41800be547791e268e7e2a9abf487943cf12 (removal of --first-parent part) is the cause of this failure.

cc @RalfJung

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Feb 26, 2025
@RalfJung
Copy link
Member

RalfJung commented Feb 26, 2025

Oh that is unfortunate, the presence of --first-parent breaks the logic as well for what is a common case in my workflow. :/ Could you post a comment in #101907 explaining the problem that arises without --first-parent?

@cuviper
Copy link
Member

cuviper commented Feb 26, 2025

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Feb 26, 2025

📌 Commit 3894725 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2025
@RalfJung
Copy link
Member

@nikic could you rebase? The 2nd commit has already landed independently.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2025
@nikic
Copy link
Contributor Author

nikic commented Feb 27, 2025

@bors r=cuviper

@bors
Copy link
Contributor

bors commented Feb 27, 2025

📌 Commit 3a71579 has been approved by cuviper

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 27, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Mar 2, 2025

@bors p=5 (encouraging more rollup-nevers to go through before more rollups)

@bors
Copy link
Contributor

bors commented Mar 2, 2025

⌛ Testing commit 3a71579 with merge f4a216d...

@Kobzol
Copy link
Contributor

Kobzol commented Mar 2, 2025

Due to the usage of smaller CI runners, jobs that have to rebuild LLVM (such as in this PR) take a very long time. If this times out (the timeout is 6h, so it's likely, given that it's 5h30m now and two jobs are still running), just retry it. It will be faster after retried due to Docker and sccache being primed.

@bors
Copy link
Contributor

bors commented Mar 2, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing f4a216d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 2, 2025
@bors bors merged commit f4a216d into rust-lang:master Mar 2, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 2, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f4a216d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 8.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
8.7% [8.7%, 8.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 8.7% [8.7%, 8.7%] 1

Cycles

Results (secondary -1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-3.1%, -2.8%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.434s -> 773.437s (-0.13%)
Artifact size: 361.97 MiB -> 361.95 MiB (-0.01%)

tgross35 added a commit to tgross35/compiler-builtins that referenced this pull request Mar 5, 2025
The fix to this issue was synced in [1] so we should no longer need to
keep aarch64 pinned.

This reverts commit b2bcfc8.

[1]: rust-lang/rust#137661
tgross35 added a commit to rust-lang/compiler-builtins that referenced this pull request Mar 5, 2025
The fix to this issue was synced in [1] so we should no longer need to
keep aarch64 pinned.

This reverts commit b2bcfc8.

[1]: rust-lang/rust#137661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants