Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make slice iterator constructors unstably const #137738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make slice iterator constructors unstably const #137738

wants to merge 1 commit into from
+57 −36

Conversation

Daniel-Aaron-Bloom
Copy link

See tracking issue for justification.

@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 27, 2025
@Daniel-Aaron-Bloom Daniel-Aaron-Bloom mentioned this pull request Feb 27, 2025
Open
3 tasks
@Daniel-Aaron-Bloom
Copy link
Author

@rustbot label -T-libs +T-libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 27, 2025
@Daniel-Aaron-Bloom
Copy link
Author

r? libs-api

@rustbot rustbot assigned m-ou-se and unassigned thomcc Feb 27, 2025
@scottmcm
Copy link
Member

It's not obvious that these are desirable yet, since other could-trivially-be-const things like https://doc.rust-lang.org/nightly/std/iter/fn.once.html aren't. Probably worth a team decision on the broader question, then the reviews would be simple.

@bors
Copy link
Contributor

bors commented Mar 16, 2025

☔ The latest upstream changes (presumably #138548) made this pull request unmergeable. Please resolve the merge conflicts.

@m-ou-se m-ou-se added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). I-libs-api-nominated Nominated for discussion during a libs-api team meeting. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025
@m-ou-se m-ou-se assigned scottmcm and unassigned m-ou-se Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Daniel-Aaron-Bloom @rustbot @scottmcm @bors @m-ou-se @thomcc