Don't drop Rvalue::WrapUnsafeBinder during GVN
#137864
Merged
+102
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
unsafe-binder-gvn
branch
from
e4e50d0 to
70b0c3e
Compare
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
oli-obk
reviewed
Mar 5, 2025
| return self.simplify_operand(op, location); | ||
| Rvalue::WrapUnsafeBinder(ref mut op, ty) => { | ||
| let value = self.simplify_operand(op, location)?; | ||
| Value::WrapUnsafeBinder(value, ty) |
There was a problem hiding this comment.
why not just produce a transmute cast?
There was a problem hiding this comment.
o true :3 that works
oli-obk
added
S-waiting-on-author
|
r=me with WrapUnsafeBinder removed |
compiler-errors
force-pushed
the
unsafe-binder-gvn
branch
from
70b0c3e to
33621bd
Compare
|
Is there a reason why we can't use transmute lowering generally in runtime MIR? |
|
errs tried it out and it didn't actually simplify things |
compiler-errors
force-pushed
the
unsafe-binder-gvn
branch
from
33621bd to
13134dd
Compare
|
@bors r=oli-obk rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2025
Rollup of 16 pull requests Successful merges: - rust-lang#133055 (Expand `CloneToUninit` documentation.) - rust-lang#137147 (Add exclude to config.toml) - rust-lang#137864 (Don't drop `Rvalue::WrapUnsafeBinder` during GVN) - rust-lang#137890 (doc: clarify that consume can be called after BufReader::peek) - rust-lang#137956 (Add RTN support to rustdoc) - rust-lang#137968 (Properly escape regexes in Python scripts) - rust-lang#138082 (Remove `#[cfg(not(test))]` gates in `core`) - rust-lang#138275 (expose `is_s390x_feature_detected!` from `std::arch`) - rust-lang#138303 (Fix Ptr inconsistency in {Rc,Arc}) - rust-lang#138309 (Add missing doc for intrinsic (Fix PR135334)) - rust-lang#138323 (Expand and organize `offset_of!` documentation.) - rust-lang#138329 (debug-assert that the size_hint is well-formed in `collect`) - rust-lang#138465 (linkchecker: bump html5ever) - rust-lang#138471 (Clean up some tests in tests/ui) - rust-lang#138472 (Add codegen test for rust-lang#129795) - rust-lang#138484 (Use lit span when suggesting suffix lit cast) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2025
Rollup merge of rust-lang#137864 - compiler-errors:unsafe-binder-gvn, r=oli-obk Don't drop `Rvalue::WrapUnsafeBinder` during GVN ...and instead use `Value::WrapUnsafeBinder` to properly propagate consts through `wrap_binder!()` in GVN. Fixes rust-lang#137846 r? oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and instead use
Value::WrapUnsafeBinderto properly propagate consts throughwrap_binder!()in GVN.Fixes #137846
r? oli-obk