Demote i686-pc-windows-gnu to Tier 2 #137869
Open
+46
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
r? Kobzol you can take a look at the CI stuff already |
Kobzol
reviewed
Mar 2, 2025
| @@ -528,31 +527,6 @@ auto: | |||
| # came from the mingw-w64 SourceForge download site. Unfortunately | |||
| # SourceForge is notoriously flaky, so we mirror it on our own infrastructure. | |||
|
|
|||
| # i686-mingw is split into three jobs to run tests in parallel. | |||
bjorn3
reviewed
Mar 2, 2025
Noratrieb
force-pushed
the
Now_I_am_become_death,_the_destroyer_of_i686-pc-windows-gnu
branch
from
cb71349 to
5e115aa
Compare
In accordance with RFC 3771. I also added a stub doc page for the target and renamed the windows-gnullvm page for consistency.
Noratrieb
force-pushed
the
Now_I_am_become_death,_the_destroyer_of_i686-pc-windows-gnu
branch
from
5e115aa to
77677fe
Compare
|
These commits modify compiler targets. |
|
r? workingjubilee I want to give you the honor of the bors r plus |
4 tasks
jieyouxu
reviewed
Mar 17, 2025
Comment on lines
-118
to
-119
| # Set of tests that should represent half of the time of the test suite. | ||
| # Used to split tests across multiple CI runners. |
There was a problem hiding this comment.
Nit: I believe this comment is still accurate (see below for ci-mingw-x and ci-mingw-bootstrap. cc @marcoieni since I could be mistaken.
There was a problem hiding this comment.
yes, those two lines are still accurate for ci-mingw-x and ci-mingw-bootstrap 👍
Can you bring them back?
Thanks for noticing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with RFC 3771. FCP has been completed.
I also added a stub doc page for the target and renamed the windows-gnullvm page for consistency.