-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: adjust expectation for f128 abi on Windows #138182
base: master
Are you sure you want to change the base?
Conversation
llvm/llvm-project@5ee1c0b updates llvm to match the documented calling convention to pass f128 indirectly. @rustbot label llvm-main
rustbot has assigned @Mark-Simulacrum. Use |
r? @tgross35 Looks OK but want to get someone more familiar with i128 to review. |
I meant to send a patch once my LLVM change merged, but we should also update our codegen to match. Could you change rust/compiler/rustc_target/src/callconv/x86_win64.rs Lines 26 to 43 in 8279176
|
@@ -37,7 +37,7 @@ pub extern "C" fn second_f64(_: f64, x: f64) -> f64 { | |||
} | |||
|
|||
// CHECK-LABEL: second_f128 | |||
// CHECK: movaps %xmm1, %xmm0 | |||
// CHECK: movaps {{(%xmm1|\(%rdx\))}}, %xmm0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add something like // FIXME(llvm21) remove xmm1 once Rust's LLVM has the ABI change
so we clean this up later?
Cc @beetrees since iirc you authored this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually if we update our codegen to match i128
, the options shouldn't be needed since it will always be (%rdx)
.
You should be able to take the CC change from #137779. |
llvm/llvm-project@5ee1c0b updates llvm to match the documented calling convention to pass f128 indirectly.
@rustbot label llvm-main
try-job: dist-x86_64-msvc
try-job: dist-x86_64-mingw
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2