Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #138348

Closed
wants to merge 29 commits into from
Closed

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 11, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

mustartt and others added 29 commits March 4, 2025 10:06
Just to avoid surprises, the amount of used keys is not large.
`bootstrap` and `llvm_enzyme` are now both in the extra `check-cfg` list
in bootstrap, so they doesn't need to be handled explicitly in
`Cargo.toml` files.
The command is called `post-merge-report` not `post-merge-analysis`.
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
The LLVM issue [1] was fixed with [2], which is included in the LLVM20
upgrade. Tests no longer fail, so enable them here.

[1]: llvm/llvm-project#98681
[2]: llvm/llvm-project#98681
…kingjubilee

[AIX] Fix hangs during testing

Fixes all current test hangs experienced during CI runs.
1. ipv6 link-local (the loopback device) gets assigned an automatic zone id of 1, causing the assert to fail and hang in `library/std/src/net/udp/tests.rs`
2. Const alloc does not fail gracefully
3. Debuginfo test has problem with gdb auto load safe path
…tty, r=jdonszelmann

Improve `-Zunpretty=hir` for parsed attrs

0. Rename `print_something` to `should_render` to make it distinct from `print_attribute` in that it doesn't print anything, it's just a way to probe if a type renders anything.
1. Fixes a few bugs in the `PrintAttribute` derive. Namely, the `__printed_anything` variable was entangled with the `should_render` call, leading us to always render field names but never render commas.
2. Remove the outermost `""` from the attr.
3. Debug print `Symbol`s. I know that this is redundant for some parsed attributes, but there's no good way to distinguish symbols that are ident-like and symbols which are cooked string literals. We could perhaps *conditionally* to fall back to a debug printing if the symbol doesn't match an ident? But seems like overkill.

Based on rust-lang#138060, only review the commits not in that one.
Add maintainers for powerpc64le-unknown-linux-gnu

The instructions are similar to `powerpc64le-unknown-linux-musl`
Document -Z crate-attr

and also add a bunch of tests
…, r=jieyouxu

add tracking issue for unqualified_local_imports

Tracking issue: rust-lang#138299

r? `````@jieyouxu`````
Allow specifying glob patterns for try jobs

This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`.

Best reviewed commit by commit.

r? `````@marcoieni`````

try-job: `*msvc*`
use next_back() instead of last() on DoubleEndedIterator
…, r=jieyouxu

Remove unnecessary `[lints.rust]` sections.

`bootstrap` and `llvm_enzyme` are now both in the extra `check-cfg` list in bootstrap, so they doesn't need to be handled explicitly in `Cargo.toml` files.

r? ``@jieyouxu``
Fix post-merge workflow

The command is called `post-merge-report` not `post-merge-analysis`. See https://github.com/rust-lang/rust/blob/90384941aae4ea38de00e4702b50757e9b882a19/src/ci/citool/src/main.rs#L379

Noticed it failing in rust-lang#138310 (comment).

r? `@Kobzol` (or `@marcoieni)`
Enable `f16` tests for `powf`

The LLVM issue [1] was fixed with [2], which is included in the LLVM20 upgrade. Tests no longer fail, so enable them here.

[1]: llvm/llvm-project#98681
[2]: llvm/llvm-project#98681

try-job: aarch64-gnu
@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Mar 11, 2025
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 11, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 11, 2025

Let's try this, my first rollup!

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Mar 11, 2025

📌 Commit a9760f4 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
@bors
Copy link
Contributor

bors commented Mar 11, 2025

⌛ Testing commit a9760f4 with merge 398b876...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang#135987 (Clarify iterator by_ref docs)
 - rust-lang#137967 ([AIX] Fix hangs during testing)
 - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs)
 - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu)
 - rust-lang#138288 (Document -Z crate-attr)
 - rust-lang#138300 (add tracking issue for unqualified_local_imports)
 - rust-lang#138307 (Allow specifying glob patterns for try jobs)
 - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator)
 - rust-lang#138330 (Remove unnecessary `[lints.rust]` sections.)
 - rust-lang#138335 (Fix post-merge workflow)
 - rust-lang#138343 (Enable `f16` tests for `powf`)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
372  |         unsafe { intrinsics::powf16(self, n) }
     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ unimplemented intrinsic: `powf16`
     |
     = help: this is likely not a bug in the program; it indicates that the program performed an operation that Miri does not support
     = note: BACKTRACE on thread `f16::test_total`:
     = note: inside `std::f16::<impl f16>::powf` at /checkout/library/std/src/f16.rs:372:18: 372:45
note: inside `f16::test_total_cmp::min_subnorm`
    --> library/std/tests/floats/f16.rs:822:29
     |
822  |         f16::MIN_POSITIVE / f16::powf(2.0, f16::MANTISSA_DIGITS as f16 - 1.0)
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `f16::test_total_cmp::max_subnorm`
    --> library/std/tests/floats/f16.rs:826:29
     |
826  |         f16::MIN_POSITIVE - min_subnorm()
     |                             ^^^^^^^^^^^^^
note: inside `f16::test_total_cmp`
    --> library/std/tests/floats/f16.rs:846:35
     |
846  |     assert_eq!(Ordering::Equal, (-max_subnorm()).total_cmp(&-max_subnorm()));
     |                                   ^^^^^^^^^^^^^
note: inside closure
    --> library/std/tests/floats/f16.rs:814:20
     |
813  | #[test]
     | ------- in this procedural macro expansion
814  | fn test_total_cmp() {
     |                    ^
     |
    ::: /checkout/library/core/src/macros/mod.rs:1651:5
     |
1651 |     pub macro test($item:item) {
     |     -------------- in this expansion of `#[test]`
note: inside `<{closure@library/std/tests/floats/f16.rs:814:1: 954:2} as std::ops::FnOnce<()>>::call_once - shim`
    --> /checkout/library/core/src/ops/function.rs:250:5
     |
250  |     extern "rust-call" fn call_once(self, args: Args) -> Self::Output;
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `<fn() -> std::result::Result<(), std::string::String> as std::ops::FnOnce<()>>::call_once - shim(fn() -> std::result::Result<(), std::string::String>)`
---
note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace

error: aborting due to 1 previous error

error: test failed, to rerun pass `-p std --test floats`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/cargo-miri runner /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/miri/x86_64-unknown-linux-gnu/debug/deps/floats-1bac60d3852da898 --skip 'fs::' --skip 'net::' --skip 'process::' --skip 'sys::pal::' -Z unstable-options --format json` (exit status: 1)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
Build completed unsuccessfully in 0:05:39
make: *** [Makefile:57: check-aux] Error 1
  local time: Tue Mar 11 12:03:18 UTC 2025
  network time: Tue, 11 Mar 2025 12:03:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Mar 11, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 11, 2025
@tgross35
Copy link
Contributor

That is from #138343

@jieyouxu
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
@jieyouxu jieyouxu closed this Mar 11, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 11, 2025

Argh, that was the only one where I wasn't feeling very confident =D Nevermind, let's try next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustc-dev-guide Area: rustc-dev-guide A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet