Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86_64-unknown-illumos LLVM target triple #138429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix x86_64-unknown-illumos LLVM target triple #138429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix x86_64-unknown-illumos LLVM target triple 
We were passing "pc" as the vendor component, which isn't present in the
rustc triple, and is inconsistent with the Aarch64 target.
@madsmtm
madsmtm committed Mar 12, 2025
commit c42e0282fff1b96eb1e3db61966b67016bca50ce
2 changes: 1 addition & 1 deletion compiler/rustc_target/src/spec/targets/x86_64_unknown_illumos.rs
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ pub(crate) fn target() -> Target {
Target {
// LLVM does not currently have a separate illumos target,
// so we still pass Solaris to it
llvm_target: "x86_64-pc-solaris".into(),
llvm_target: "x86_64-unknown-solaris".into(),
metadata: TargetMetadata {
description: Some("illumos".into()),
tier: Some(2),
Loading