-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add succinct-zkvm
os and target
#138463
base: master
Are you sure you want to change the base?
Conversation
These commits modify compiler targets. |
succinct-zkvm
os and target
Amended description with the std-lib pr. |
@jieyouxu tagging you here as I saw you did |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It is correct. I will roll a compiler lead (see https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#targets). r? compiler_leads |
Please also include a Platform Support page, see https://doc.rust-lang.org/rustc/target-tier-policy.html#adding-a-new-target. |
added thanks |
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
This comment has been minimized.
This comment has been minimized.
c7bcb1f
to
f9accfb
Compare
f9accfb
to
7e69cf7
Compare
Updated to fix tidy lint |
This comment has been minimized.
This comment has been minimized.
@@ -1954,6 +1954,7 @@ supported_targets! { | |||
|
|||
("riscv32i-unknown-none-elf", riscv32i_unknown_none_elf), | |||
("riscv32im-risc0-zkvm-elf", riscv32im_risc0_zkvm_elf), | |||
("riscv32im-succinct-zkvm-elf", riscv32im_succinct_zkvm_elf), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By putting a dash in the target OS, you make it look like it's vendor:succinct, os:zkvm. I would recommend calling it riscv32im-succinct_zkvm-elf
or even just rustc32im-succinct-elf
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
UI tests should be fixed now! |
Adds the
succinct-zkvm
target and operating system. I will amend this descprtion with a PR to add std-lib support shortlyEDIT: std-lib PR currently maintained on my fork.
https://github.com/succinctlabs/rust-fork/pull/1/files
Tier 3 Policy:
Understood.
This PR uses existing
zkvm
target triple style.Understood
Understood
Understood
Understood
Understood.
Understood.
Understood.
Understood, in progress.
Understood
Understood.