Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Avoid some unstable iteration #138502

Merged
merged 1 commit into from
Mar 15, 2025
Merged

resolve: Avoid some unstable iteration #138502

merged 1 commit into from
Mar 15, 2025
+51 −41

Conversation

petrochenkov
Copy link
Contributor

This PR replaces #131213.

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2025
@petrochenkov petrochenkov mentioned this pull request Mar 14, 2025
Closed
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 14, 2025
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
@bors
Auto merge of rust-lang#138502 - petrochenkov:resinstab, r=<try>
a1764f5 
resolve: Avoid some unstable iteration

This PR replaces rust-lang#131213.
@bors
Copy link
Contributor

bors commented Mar 14, 2025

⌛ Trying commit a891139 with merge a1764f5...

@bors
Copy link
Contributor

bors commented Mar 14, 2025

☀️ Try build successful - checks-actions
Build commit: a1764f5 (a1764f59056ad38a8c953800d493de44c5f234dd)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a1764f5): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.2% [0.2%, 0.3%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.0%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [1.2%, 3.3%] 3
Improvements ✅
(primary)		 -1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.364s -> 773.691s (-0.22%)
Artifact size: 365.01 MiB -> 365.03 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 14, 2025
@compiler-errors
Copy link
Member

Possibly not noise but definitely worth the fixing here

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2025

📌 Commit a891139 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 14, 2025
@petrochenkov
Copy link
Contributor Author

@bors rollup=maybe

@matthiaskrgr matthiaskrgr mentioned this pull request Mar 15, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2025
@bors
Auto merge of rust-lang#138532 - matthiaskrgr:rollup-mgcynqu, r=matth…
4d30011 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#138283 (Enforce type of const param correctly in MIR typeck)
 - rust-lang#138439 (feat: check ARG_MAX on Unix platforms)
 - rust-lang#138502 (resolve: Avoid some unstable iteration)
 - rust-lang#138514 (Remove fake borrows of refs that are converted into non-refs in `MakeByMoveBody`)
 - rust-lang#138524 (Mark myself as unavailable for reviews temporarily)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 232ec5c into rust-lang:master Mar 15, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 15, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2025
@rust-timer
Unrolled build for rust-lang#138502
149a339 
Rollup merge of rust-lang#138502 - petrochenkov:resinstab, r=compiler-errors

resolve: Avoid some unstable iteration

This PR replaces rust-lang#131213.
@petrochenkov petrochenkov mentioned this pull request Mar 16, 2025
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2025
@bors
Auto merge of rust-lang#138580 - petrochenkov:resinstab, r=<try>
76b788c 
resolve: Avoid some unstable iteration 2

Continuation of rust-lang#138502.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2025
@bors
Auto merge of rust-lang#138580 - petrochenkov:resinstab, r=Nadrieril
0e34c65 
resolve: Avoid some unstable iteration 2

Continuation of rust-lang#138502.
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 22, 2025
@tgross35
Rollup merge of rust-lang#138580 - petrochenkov:resinstab, r=Nadrieril
87c2a9f 
resolve: Avoid some unstable iteration 2

Continuation of rust-lang#138502.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@petrochenkov @rustbot @rust-timer @bors @compiler-errors @cjgillot