Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure no index out of bounds panic (#135474) #138509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reddevilmidzy
Copy link
Contributor

Adds test for #135474

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2025
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs a better name and should be placed into a subdirectory of tests/ui corresponding to what the test is exercising, rather than the top-level.

Specifically, I think you should look back at the original issue and/or the PR that fixed the issue to understand what was wrong with the code in the first place and/or why the issue was fixed, so that this can be named more accurately.

@compiler-errors
Copy link
Member

@rustbot author
r? compiler-errors

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@rustbot rustbot assigned compiler-errors and unassigned davidtwco Mar 14, 2025
@reddevilmidzy
Copy link
Contributor Author

Thanks for the feedback! I've moved the test to the tests/ui/fn directory. I also reviewed the original PR (#136497) to better understand the context and ensure the test is more accurately placed.

Additionally, I've renamed the test from impl-sized to trait-fn-generic-mismatch

Let me know if you have any further suggestions!

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2025
@compiler-errors
Copy link
Member

Please squash this into one commit. there doesn't need to be a commit to move a file or to remove whitespace, for example. It's just one file after all :) Then I can approve.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025
@reddevilmidzy
Copy link
Contributor Author

Squashed the commits into one as requested. Thanks for the review! 😊

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2025
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 22, 2025

📌 Commit b523301 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants