-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to ensure no index out of bounds panic (#135474) #138509
base: master
Are you sure you want to change the base?
Conversation
r? @davidtwco rustbot has assigned @davidtwco. Use |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test needs a better name and should be placed into a subdirectory of tests/ui
corresponding to what the test is exercising, rather than the top-level.
Specifically, I think you should look back at the original issue and/or the PR that fixed the issue to understand what was wrong with the code in the first place and/or why the issue was fixed, so that this can be named more accurately.
@rustbot author |
Thanks for the feedback! I've moved the test to the Additionally, I've renamed the test from Let me know if you have any further suggestions! |
This comment has been minimized.
This comment has been minimized.
Please squash this into one commit. there doesn't need to be a commit to move a file or to remove whitespace, for example. It's just one file after all :) Then I can approve. @rustbot author |
Squashed the commits into one as requested. Thanks for the review! 😊 @rustbot ready |
@bors r+ rollup |
Adds test for #135474