Suggest crate keyword when unresolved path contains current crate's name
#138529
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prioritizing the added check for the crate's name at the top of `report_path_resolution_error()` seems to account for differences in Rust 2015 and 2018's crate/module path systems, allowing the same suggestion to show up for Rust 2015.
(The `help` annotation was missing due to an issue that, admittedly, resulted from a typo I stared at and didn't catch.)
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #138312.
Unsure about the second "help" message suggested by the issue writer, but for at least the main part of the issue, I've added a check to emit a suggestion replacing the current crate's name in a path with
crate. Let me know if there's a more elegant way to do this.