Add integer to string formatting tests #138546
Open
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
GuillaumeGomez
force-pushed
the
integer-to-string-tests
branch
from
09c42c7 to
47b2f7f
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
integer-to-string-tests
branch
from
47b2f7f to
b2b1ed2
Compare
This comment has been minimized.
This comment has been minimized.
|
FYI (very recent change) alloc tests are now a separate package, alloctests EDIT: see #136642 |
jieyouxu
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
integer-to-string-tests
branch
from
b2b1ed2 to
bacd57a
Compare
|
Wow, talk about bad luck. 😆 Thanks for the links @jieyouxu! Updated the PR to use |
library/alloctests/tests/num.rs
Outdated
|
|
||
| fn assert_nb<Int: ToString + FromStr + Debug + Display + Eq>(value: Int) { | ||
| let s = value.to_string(); | ||
| let s2 = format!("{}", value); |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
integer-to-string-tests
branch
from
1cf1166 to
25900c2
Compare
|
Forgot to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #136264, there doesn't seem to have tests to ensure that int to string conversion is performed correctly, only sporadic tests here and there. Now we have some basic tests. :)
r? @Mark-Simulacrum