Use strip_{prefix|suffix} instead of {starts|ends}_with+indexing

[yotamofek]

Randomly scratching an itch 😁

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

HIR ty lowering was modified

cc @fmease

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

[nnethercote]

Nice to remove these magic numbers, thanks. Just a couple of minor nits to address.

[yotamofek]

@rustbot review

[nnethercote]

@bors r+

[bors]

📌 Commit a3e4dff has been approved by nnethercote

It is now in the queue for this repository.

[bors]

⌛ Testing commit a3e4dff with merge 9bad8ac...

[bors]

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 9bad8ac to master...

[github-actions]

This is an experimental post-merge analysis report. You can ignore it.

Post-merge report

Comparing 10bcdad (base) -> 9bad8ac (this PR)

Test differences

No test diffs found

[rust-timer]

Finished benchmarking commit (9bad8ac): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.3%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.561s -> 776.387s (0.11%)
Artifact size: 365.14 MiB -> 365.11 MiB (-0.01%)