Don't require `alloca`s for consuming simple enums #138582

scottmcm · 2025-03-16T23:53:51Z

For example, if you pass an Option<u32> to a function, don't immediately write it to an alloca then read it again.

rustbot · 2025-03-16T23:53:55Z

rustbot has assigned @saethlin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

scottmcm · 2025-03-17T00:13:27Z

@bors try @rust-timer queue

bors · 2025-03-17T00:14:38Z

⌛ Trying commit 019c41a with merge a5a9937...

Don't require `alloca`s for creating or consuming simple enums This lets, for example, `Option<u32>` stay a `ScalarPair` the whole time, never needing to get written to stack.

bors · 2025-03-17T02:20:35Z

☀️ Try build successful - checks-actions
Build commit: a5a9937 (a5a99374d77fd499d01fb91c55bcb4ef8dad712a)

rust-timer · 2025-03-17T03:39:46Z

Finished benchmarking commit (a5a9937): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 1.6%]	187
Regressions ❌ (secondary)	0.6%	[0.2%, 6.7%]	129
Improvements ✅ (primary)	-0.5%	[-1.0%, -0.3%]	9
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-1.0%, 1.6%]	196

Max RSS (memory usage)

Results (primary -2.0%, secondary 1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Cycles

Results (primary 1.1%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.8%, 1.5%]	11
Regressions ❌ (secondary)	2.5%	[1.1%, 3.5%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	1.1%	[0.8%, 1.5%]	11

Binary size

Results (primary -0.2%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	20
Improvements ✅ (primary)	-0.2%	[-0.6%, -0.0%]	65
Improvements ✅ (secondary)	-0.1%	[-0.3%, -0.0%]	22
All ❌✅ (primary)	-0.2%	[-0.6%, -0.0%]	65

Bootstrap: 775.741s -> 776.411s (0.09%)
Artifact size: 365.10 MiB -> 364.26 MiB (-0.23%)

scottmcm · 2025-03-17T07:47:45Z

Wow, those numbers are horrible :/

(Well, other than the size improvements)

rust-log-analyzer · 2025-03-17T08:31:46Z

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#19 exporting to docker image format
#19 sending tarball 20.6s done
#19 DONE 25.4s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
  Number of decisions:   4447
  longest path:          1159 (code:    152)
  longest backtrack:       66 (code:    428)
Shared 86733 out of 152951 states by creating 14756 new states, saving 71977
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/expmed.cc: In function ‘rtx_def* extract_bit_field_1(rtx, poly_uint64, poly_uint64, int, rtx, machine_mode, machine_mode, bool, bool, rtx_def**)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/expmed.cc:1864:45: warning: ‘*(unsigned int*)((char*)&imode + offsetof(scalar_int_mode, scalar_int_mode::m_mode))’ may be used uninitialized [-Wmaybe-uninitialized]
 1864 |       rtx sub = extract_bit_field_as_subreg (mode1, op0, imode,
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
 1865 |                                              bitsize, bitnum);
      |                                              ~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/expmed.cc:1824:19: note: ‘*(unsigned int*)((char*)&imode + offsetof(scalar_int_mode, scalar_int_mode::m_mode))’ was declared here
 1824 |   scalar_int_mode imode;
      |                   ^~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gimple-range-gori.cc: In member function ‘void range_def_chain::dump(FILE*, basic_block, const char*)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gimple-range-gori.cc:319:19: warning: format not a string literal and no format arguments [-Wformat-security]
  319 |           fprintf (f, prefix);
      |           ~~~~~~~~^~~~~~~~~~~
---
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gcc.cc:7930:9: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 7930 |   write (fd, "\n\n", 2);
      |   ~~~~~~^~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gcc.cc: In member function ‘void driver::final_actions() const’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gcc.cc:9307:13: warning: ignoring return value of ‘int truncate(const char*, __off_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 9307 |     truncate(totruncate_file, 0);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gengtype-lex.l: In function ‘int yylex(const char**)’:
gengtype-lex.cc:357:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
  357 | #define YY_DO_BEFORE_ACTION \
      |  ~~~~~~~~~~~~~^~~~~~~
---
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc: In function ‘void lto_resolution_read(splay_tree, FILE*, lto_file*)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc:2091:10: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2091 |   fscanf (resolution, " ");   /* Read white space.  */
      |   ~~~~~~~^~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc:2093:9: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2093 |   fread (obj_name, sizeof (char), name_len, resolution);
      |   ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc:2113:10: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2113 |   fscanf (resolution, "%u", &num_symbols);
      |   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/jit/jit-recording.cc:32:
---
Applying io_quotes_use            to linux/blkzoned.h
Applying io_quotes_use            to linux/ipmi.h
Applying io_quotes_use            to linux/psp-dbc.h
Applying io_quotes_use            to linux/bt-bmc.h
Applying io_quotes_use            to linux/tps6594_pfsm.h
Applying io_quotes_use            to linux/cxl_mem.h
Applying io_quotes_use            to linux/wmi.h
Applying io_quotes_use            to linux/auto_fs.h
Applying io_quotes_use            to linux/mmtimer.h
Applying io_quotes_use            to linux/f2fs.h
Applying io_quotes_use            to linux/vhost.h
---
Applying machine_name             to x86_64-linux-gnu/bits/unistd_ext.h
Applying io_quotes_use            to x86_64-linux-gnu/asm/mtrr.h
Applying io_quotes_use            to x86_64-linux-gnu/asm/amd_hsmp.h
Applying machine_name             to openssl/e_os2.h
Applying io_quotes_use            to drm/xe_drm.h
Applying io_quotes_use            to drm/radeon_drm.h
Applying io_quotes_use            to drm/panfrost_drm.h
Applying io_quotes_use            to drm/etnaviv_drm.h
Applying io_quotes_use            to drm/lima_drm.h
Applying io_quotes_use            to drm/qaic_accel.h
Applying io_quotes_use            to drm/vc4_drm.h
Applying io_quotes_use            to drm/i915_drm.h
Applying io_quotes_use            to drm/omap_drm.h
Applying io_quotes_use            to drm/pvr_drm.h
Applying io_quotes_use            to drm/amdgpu_drm.h
Applying io_quotes_use            to drm/vgem_drm.h
Applying io_quotes_use            to drm/msm_drm.h
Applying io_quotes_use            to drm/v3d_drm.h
Applying io_quotes_use            to drm/exynos_drm.h
Applying io_quotes_use            to drm/nouveau_drm.h
Applying io_quotes_use            to drm/drm.h
Applying io_quotes_use            to drm/habanalabs_accel.h
Applying io_quotes_use            to drm/tegra_drm.h
Applying io_quotes_use            to rdma/rdma_user_ioctl.h
cc1: note: self-tests are not enabled in this build
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/c++tools/server.cc: In function ‘void server(bool, int, module_resolver*)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/c++tools/server.cc:620:10: warning: ignoring return value of ‘int pipe(int*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
---
failures:

---- [codegen] tests/codegen/common_prim_int_ptr.rs stdout ----

error: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-18/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/common_prim_int_ptr/common_prim_int_ptr.ll" "/checkout/tests/codegen/common_prim_int_ptr.rs" "--check-prefix=CHECK" "--allow-unused-prefixes" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
/checkout/tests/codegen/common_prim_int_ptr.rs:46:12: error: CHECK: expected string not found in input
 // CHECK: [[NOT_OK:%.+]] = icmp ne i{{[0-9]+}} [[DISCRIMINANT]], 0
           ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/common_prim_int_ptr/common_prim_int_ptr.ll:31:102: note: scanning from here
define noundef nonnull align 4 ptr @extract_box(i64 noundef %x.0, ptr noundef readnone returned %x.1) unnamed_addr #1 {
                                                                                                     ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/common_prim_int_ptr/common_prim_int_ptr.ll:31:102: note: with "DISCRIMINANT" equal to "%x\\.0"
define noundef nonnull align 4 ptr @extract_box(i64 noundef %x.0, ptr noundef readnone returned %x.1) unnamed_addr #1 {
                                                                                                     ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/common_prim_int_ptr/common_prim_int_ptr.ll:33:2: note: possible intended match here
 %_3 = icmp eq i64 %x.0, 1
 ^

Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/common_prim_int_ptr/common_prim_int_ptr.ll
Check file: /checkout/tests/codegen/common_prim_int_ptr.rs

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1: ; ModuleID = 'common_prim_int_ptr.6a84fe6a950ca3c2-cgu.0' 
            2: source_filename = "common_prim_int_ptr.6a84fe6a950ca3c2-cgu.0" 
            3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128" 
            4: target triple = "x86_64-unknown-linux-gnu" 
            5:  
            6: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind willreturn memory(none) uwtable 
            7: define { i64, ptr } @insert_int(i64 noundef %x) unnamed_addr #0 { 
            8: start: 
            9:  %0 = inttoptr i64 %x to ptr 
           10:  %1 = insertvalue { i64, ptr } { i64 0, ptr poison }, ptr %0, 1 
           11:  ret { i64, ptr } %1 
           12: } 
           13:  
           14: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind willreturn memory(none) uwtable 
           15: define { i64, ptr } @insert_box(ptr noalias noundef nonnull align 1 %x) unnamed_addr #0 { 
           16: start: 
           17:  %0 = insertvalue { i64, ptr } { i64 1, ptr poison }, ptr %x, 1 
           18:  ret { i64, ptr } %0 
           19: } 
           20:  
           21: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind willreturn memory(inaccessiblemem: write) uwtable 
           22: define noundef i64 @extract_int(i64 noundef %0, ptr noundef %1) unnamed_addr #1 personality ptr @rust_eh_personality { 
           23: start: 
           24:  %_3 = icmp eq i64 %0, 0 
           25:  tail call void @llvm.assume(i1 %_3) 
           26:  %v.cast = ptrtoint ptr %1 to i64 
           27:  ret i64 %v.cast 
           28: } 
           29:  
           30: ; Function Attrs: mustprogress nofree norecurse nosync nounwind nonlazybind willreturn memory(inaccessiblemem: write) uwtable 
           31: define noundef nonnull align 4 ptr @extract_box(i64 noundef %x.0, ptr noundef readnone returned %x.1) unnamed_addr #1 { 
check:46'0                                                                                                          X~~~~~~~~~~~~~~~~~~ error: no match found
check:46'1                                                                                                                              with "DISCRIMINANT" equal to "%x\\.0"
           32: start: 
check:46'0     ~~~~~~~
           33:  %_3 = icmp eq i64 %x.0, 1 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:46'2      ?                          possible intended match
           34:  tail call void @llvm.assume(i1 %_3) 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           35:  %0 = icmp ne ptr %x.1, null 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           36:  tail call void @llvm.assume(i1 %0) 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           37:  ret ptr %x.1 
check:46'0     ~~~~~~~~~~~~~~
           38: } 
check:46'0     ~~
           39:  
check:46'0     ~
           40: ; Function Attrs: mustprogress nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           41: declare void @llvm.assume(i1 noundef) #2 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           42:  
check:46'0     ~
           43: ; Function Attrs: nounwind nonlazybind uwtable 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           44: declare noundef i32 @rust_eh_personality(i32 noundef, i32 noundef, i64 noundef, ptr noundef, ptr noundef) unnamed_addr #3 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           45:  
check:46'0     ~
           46: attributes #0 = { mustprogress nofree norecurse nosync nounwind nonlazybind willreturn memory(none) uwtable "probe-stack"="inline-asm" "target-cpu"="x86-64" } 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           47: attributes #1 = { mustprogress nofree norecurse nosync nounwind nonlazybind willreturn memory(inaccessiblemem: write) uwtable "probe-stack"="inline-asm" "target-cpu"="x86-64" } 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           48: attributes #2 = { mustprogress nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           49: attributes #3 = { nounwind nonlazybind uwtable "probe-stack"="inline-asm" "target-cpu"="x86-64" } 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           50:  
check:46'0     ~
           51: !llvm.module.flags = !{!0, !1} 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           52: !llvm.ident = !{!2} 
check:46'0     ~~~~~~~~~~~~~~~~~~~~
           53:  
check:46'0     ~
           54: !0 = !{i32 8, !"PIC Level", i32 2} 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           55: !1 = !{i32 2, !"RtLibUseGOT", i32 1} 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           56: !2 = !{!"rustc version 1.87.0-nightly (0b253304c 2025-03-17)"} 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>>>
------------------------------------------

scottmcm · 2025-03-17T17:33:48Z

@bors try @rust-timer queue

Don't require `alloca`s for consuming simple enums For example, if you pass an `Option<u32>` to a function, don't immediately write it to an `alloca` then read it again.

bors · 2025-03-17T17:35:00Z

⌛ Trying commit 3477a13 with merge 132433d...

bors · 2025-03-17T19:44:20Z

☀️ Try build successful - checks-actions
Build commit: 132433d (132433d7556f612643abac6a48c4b80911f5e9f4)

rust-timer · 2025-03-17T21:40:10Z

Finished benchmarking commit (132433d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.5%]	9
Regressions ❌ (secondary)	0.5%	[0.2%, 1.4%]	45
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	14
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	3
All ❌✅ (primary)	-0.1%	[-0.8%, 0.5%]	23

Max RSS (memory usage)

Results (primary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

Results (secondary 3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[2.4%, 5.4%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	38
Improvements ✅ (primary)	-0.1%	[-0.4%, -0.0%]	54
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.4%, 0.0%]	58

Bootstrap: 774.895s -> 775.425s (0.07%)
Artifact size: 365.10 MiB -> 365.16 MiB (0.02%)

scottmcm · 2025-03-18T00:59:11Z

Wow, that one's almost entirely green in primary and almost entirely red in secondary O_o

rustbot assigned saethlin Mar 16, 2025

rustbot added S-waiting-on-review T-compiler labels Mar 16, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf label Mar 17, 2025

This comment has been minimized.

Sign in to view

scottmcm mentioned this pull request Mar 17, 2025

Simple Option use, like in checked_sub, should optimize out fully in MIR #138544

Open

This comment has been minimized.

Sign in to view

rustbot added perf-regression and removed S-waiting-on-perf labels Mar 17, 2025

scottmcm changed the title ~~Don't require allocas for creating or consuming simple enums~~ Don't require allocas for consuming simple enums Mar 17, 2025

Allow reading from Option<u32> without needing an alloca

3477a13

scottmcm force-pushed the option-ssa-2 branch from 019c41a to 3477a13 Compare March 17, 2025 07:58

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf label Mar 17, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf label Mar 17, 2025

scottmcm mentioned this pull request Mar 23, 2025

Simplify PartialOrd on tuples containing primitives #138135

Open

scottmcm added S-waiting-on-author and removed S-waiting-on-review labels Mar 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't require `alloca`s for consuming simple enums #138582

Don't require `alloca`s for consuming simple enums #138582

scottmcm commented Mar 16, 2025 •

edited

Loading

rustbot commented Mar 16, 2025

scottmcm commented Mar 17, 2025

This comment has been minimized.

bors commented Mar 17, 2025

This comment has been minimized.

bors commented Mar 17, 2025

This comment has been minimized.

rust-timer commented Mar 17, 2025

scottmcm commented Mar 17, 2025 •

edited

Loading

rust-log-analyzer commented Mar 17, 2025

scottmcm commented Mar 17, 2025

This comment has been minimized.

bors commented Mar 17, 2025

bors commented Mar 17, 2025

This comment has been minimized.

rust-timer commented Mar 17, 2025

scottmcm commented Mar 18, 2025

Don't require allocas for consuming simple enums #138582

Are you sure you want to change the base?

Don't require allocas for consuming simple enums #138582

Conversation

scottmcm commented Mar 16, 2025 • edited Loading

rustbot commented Mar 16, 2025

scottmcm commented Mar 17, 2025

This comment has been minimized.

bors commented Mar 17, 2025

This comment has been minimized.

bors commented Mar 17, 2025

This comment has been minimized.

rust-timer commented Mar 17, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

scottmcm commented Mar 17, 2025 • edited Loading

rust-log-analyzer commented Mar 17, 2025

scottmcm commented Mar 17, 2025

This comment has been minimized.

bors commented Mar 17, 2025

bors commented Mar 17, 2025

This comment has been minimized.

rust-timer commented Mar 17, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

scottmcm commented Mar 18, 2025

Don't require `alloca`s for consuming simple enums #138582

Don't require `alloca`s for consuming simple enums #138582

scottmcm commented Mar 16, 2025 •

edited

Loading

scottmcm commented Mar 17, 2025 •

edited

Loading