Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #138680

Closed
wants to merge 8 commits into from
Closed

Conversation

Sakib25800
Copy link

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

hkBst and others added 8 commits January 28, 2025 10:34
`rustc_index` is only used for its size assertion macro, so demote it to a dev-dependency gated under testing instead
Co-authored-by: Ibraheem Ahmed <ibraheem@ibraheem.ca>
clarify BufRead::{fill_buf, consume} docs

Fixes rust-lang#85394
…owLii

Slim `rustc_parse_format` dependencies down

`rustc_index` is only used for its size assertion macro, so demote it to a dev-dependency gated under testing instead. This allows the crate to built without having to wait for `syn` (pulled in by `rustc_index_macros`)

Alternatively we could inline the macro, though from the looks of it that will run into trouble with `rustc_randomized_layouts`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

Error: Label rollup can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@Sakib25800 Sakib25800 closed this Mar 19, 2025
@Sakib25800 Sakib25800 deleted the rollup-bntnvjq branch March 19, 2025 01:15
@Sakib25800
Copy link
Author

Sakib25800 commented Mar 19, 2025

Whoops, sorry for making this rollup. Please ignore this. I was just trying to understand how Bors works 🤦‍♂️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants