Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portable SIMD subtree update #138687

Merged
merged 12 commits into from
Mar 20, 2025
Merged

Portable SIMD subtree update #138687

merged 12 commits into from
Mar 20, 2025

Conversation

calebzulawski
Copy link
Member

No description provided.

programmerjake and others added 12 commits January 24, 2025 01:04
@programmerjake
update llvm workaround comment to link to rust tracking issue too
d545e84
@ehuss
Migrate core_simd to Rust 2024
2b5f6f0
@ehuss
Apply style_edition 2024
007e0f1
@calebzulawski
Merge pull request rust-lang#451 from ehuss/rust-2024
b4f4785 
Migrate core_simd to Rust 2024
@thaliaarchi
Use size_of from the prelude instead of imported
c86f0a1 
Use `std::mem::{size_of, size_of_val, align_of, align_of_val}` from the
prelude instead of importing or qualifying them.

These functions were added to all preludes in Rust 1.80.
@calebzulawski
Merge pull request rust-lang#454 from thaliaarchi/use-prelude-size-of
74cddca 
Use `size_of` from the prelude instead of imported
@Urgau
Deny unreachable_pub lint
85d15a4 
As is done in `core` since rust-lang#134286

cc rust-lang#138054
@calebzulawski
Merge pull request rust-lang#455 from Urgau/deny-unreachable_pub
c659647 
Deny `unreachable_pub` lint
@calebzulawski
Merge pull request rust-lang#450 from programmerjake/update-llvm-work…
abd5d05 
…around-comment

update llvm workaround comment to link to rust tracking issue too
@folkertdev
add examples for shift_elements_{left, right} and `rotate_elements_…
85a494b 
…{left, right}`
@calebzulawski
Merge pull request rust-lang#452 from folkertdev/element-rotate-example
c14f2fc 
add examples for `shift_elements_{left, right}` and `rotate_elements_{left, right}`
@calebzulawski
Merge commit 'c14f2fc3eb69c164d8bf8d36d91ebd60bd5261e6' into sync-fro…
3c705b8 
…m-portable-simd-2025-03-19
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

@calebzulawski
Copy link
Member Author

whoops
r? @workingjubilee

@calebzulawski
Copy link
Member Author

commit history looks good to me this time.

@calebzulawski calebzulawski mentioned this pull request Mar 19, 2025
Closed
@workingjubilee
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 19, 2025

📌 Commit 3c705b8 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2025
@bors
Copy link
Contributor

bors commented Mar 20, 2025

⌛ Testing commit 3c705b8 with merge 70237a8...

@calebzulawski
Copy link
Member Author

cc @Urgau

@bors
Copy link
Contributor

bors commented Mar 20, 2025

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 70237a8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 20, 2025
@bors bors merged commit 70237a8 into rust-lang:master Mar 20, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 20, 2025
@github-actions GitHub Actions
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2947be7 (parent) -> 70237a8 (this PR)

Test differences

Show 40 test diffs

Additionally, 40 doctest diffs were found. These are ignored, as they are noisy.

Job group index

@Urgau Urgau mentioned this pull request Mar 20, 2025
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (70237a8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.9%, secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 5.1% [5.1%, 5.1%] 1
Regressions ❌
(secondary)		 2.0% [1.8%, 2.2%] 3
Improvements ✅
(primary)		 -6.8% [-6.8%, -6.8%] 1
Improvements ✅
(secondary)		 -2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) -0.9% [-6.8%, 5.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.968s -> 773.52s (-0.19%)
Artifact size: 365.49 MiB -> 365.50 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.