build dist for x86_64-pc-solaris and sparcv9-sun-solaris

[psumbera]

FIx for #126025

Note that this needs Nix with following commit:
nix-rust/nix@0f45593
Unfortunatelly there is no new release.

And for sparcv9 it needs also:
tov/libffi-rs#103

For now it therefore uses cargo patch infrastructure for these.

[rustbot]

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[Veykril]

This is not going to happen, this will break our crates-io releases.

[psumbera]

Is waiting for new nix version the only option here? Last nix release is from May 2024..

[jieyouxu]

Unfortunately I think that's the case, AFAIK neither r-a nor the root manifest here can use cargo patch functionality.

For the root manifest here, I believe we can't be pointing to non-rust-lang/* forks via git dependencies too for supply-chain security reasons, cc @pietroalbini.

[jieyouxu]

These should be fixed upstream, we really cannot be repointing these deps to the non-upstream forks.

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

info: removing rustup binaries
info: rustup is uninstalled
##[group]Image checksum input
mingw-check-tidy
# We use the ghcr base image because ghcr doesn't have a rate limit
# and the mingw-check-tidy job doesn't cache docker images in CI.
FROM ghcr.io/rust-lang/ubuntu:22.04

ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
  g++ \
  make \
---

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#12 2.701 Building wheels for collected packages: reuse
#12 2.702   Building wheel for reuse (pyproject.toml): started
#12 2.915   Building wheel for reuse (pyproject.toml): finished with status 'done'
#12 2.916   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=0c2fd2aaf7b0bf8d6e131220aff14712a774c2ca462f3204d25460cbcf610b63
#12 2.916   Stored in directory: /tmp/pip-ephem-wheel-cache-1up5e5rv/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#12 2.918 Successfully built reuse
#12 2.919 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#12 3.314 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#12 3.314 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 3.848 Collecting virtualenv
#12 3.907   Downloading virtualenv-20.29.3-py3-none-any.whl (4.3 MB)
#12 3.974      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 66.2 MB/s eta 0:00:00
#12 4.030 Collecting platformdirs<5,>=3.9.1
#12 4.034   Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#12 4.072 Collecting filelock<4,>=3.12.2
#12 4.075   Downloading filelock-3.18.0-py3-none-any.whl (16 kB)
#12 4.092 Collecting distlib<1,>=0.3.7
#12 4.096   Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#12 4.104      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 80.1 MB/s eta 0:00:00
#12 4.185 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#12 4.366 Successfully installed distlib-0.3.9 filelock-3.18.0 platformdirs-4.3.6 virtualenv-20.29.3
#12 4.366 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 DONE 4.4s

#13 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#13 DONE 0.0s
---
DirectMap4k:      135104 kB
DirectMap2M:     8253440 kB
DirectMap1G:    10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
[TIMING] core::build_steps::tool::LibcxxVersionTool { target: x86_64-unknown-linux-gnu } -- 0.216
---
extracting /checkout/obj/build/cache/llvm-1370611c0ae0c7232bcd073e15046bae6b519e50-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
[TIMING] core::build_steps::compile::Sysroot { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, force_recompile: false } -- 18.170
[TIMING] core::builder::Libdir { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.010
##[group]Building stage0 tool tidy (x86_64-unknown-linux-gnu)
    Updating git repository `https://github.com/psumbera/libffi-rs.git`
    Updating git repository `https://github.com/psumbera/nix.git`
    Updating crates.io index
---
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
fmt: checked 5917 files
tidy check
tidy error: invalid source: "git+https://github.com/psumbera/libffi-rs.git?branch=sparcv9#dff93b3d171736632ce48f9cb07548f30ccc9f61"
tidy error: invalid source: "git+https://github.com/psumbera/nix.git?branch=mypatch#9491d8fb08f8d104cd7b421121142bb82ea3ad6d"
tidy error: invalid source: "git+https://github.com/psumbera/nix.git?branch=mypatch-v28#140320211308037d7e1bd32a9884a936737ac59f"
tidy: Skipping binary file check, read-only filesystem
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (25.0.1)
linting python files
All checks passed!
checking python file formatting
26 files already formatted
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:50
  local time: Wed Mar 19 11:12:06 UTC 2025
  network time: Wed, 19 Mar 2025 11:12:06 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

[jieyouxu]

(That being said, thank you for investigating fixes for the Solaris CI)