-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid hashing the hir_crate query #138772
base: master
Are you sure you want to change the base?
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Avoid hashing the hir_crate query related reading: rust-lang#94852 Basically I want to move the crate hashing to the `crate_hash` query and make it work off `hir_crate_items` instead of `hir_crate`. So this is a step towards that, if perf allows it. r? `@ghost`
…try> Avoid directly accessing the hir_crate query from crate_hash based on rust-lang#138772 cc rust-lang#95004 Move the crate hashing to the crate_hash query and make it work off hir_crate_items instead of hir_crate. r? `@ghost`
…try> Avoid directly accessing the hir_crate query from crate_hash based on rust-lang#138772 cc rust-lang#95004 Move the crate hashing to the crate_hash query and make it work off hir_crate_items instead of hir_crate. r? `@ghost`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (e413ff3): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary 3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.966s -> 774.366s (-0.08%) |
related reading: #94852
cc #95004
Basically I want to move the crate hashing to the
crate_hash
query and make it work offhir_crate_items
instead ofhir_crate
. So this is a step towards that, if perf allows it.r? @ghost