Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try not to use verbatim paths in Command::current_dir #138869

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Try not to use verbatim paths in Command::current_dir #138869

wants to merge 2 commits into from
+118 −4

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Mar 23, 2025 •
edited
Loading

If possible, we should try not to use verbatim paths in Command::current_dir. It might work but it might also break code in the subprocess that assume the current directory isn't verbatim (including Windows APIs). cc @ehuss

Side note: we now have a lot of ad-hoc fixes like this spread about the place. It'd be good to make a proper WindowsPath type that handles all this in one place. But that's a bigger job for another PR.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 23, 2025
Noratrieb
Noratrieb reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks reasonable to me, but I'd like someone with more clues about Windows to take a look as well. I don't know who'd be a great fit, feel free to assign whoever you want

@ChrisDenton
Test Command::current_dir with verbatim path
a6e4d03
@ChrisDenton
Avoid verbatim paths in Command::current_dir
9be8b3a 
If possible, we should try not to use verbatim paths in Command::current_dir. It might work but it might also break code (including some Windows APIs) that assume the current directory isn't verbatim.
@ChrisDenton
Copy link
Member Author

I'd like someone with more clues about Windows to take a look as well

I'm honestly not sure, so choosing someone at random:
r? @tgross35
Want to take a stab at this? Feel free to pass.

@rustbot rustbot assigned tgross35 and unassigned Noratrieb Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisDenton @Noratrieb @tgross35 @rustbot