Rename is_like_osx to is_like_darwin
#138949
Open
+54
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
These commits modify compiler targets. Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs |
| self.vendor == "apple", | ||
| "`is_like_osx` must be set if and only if `vendor` is `apple`" | ||
| "`is_like_darwin` must be set if and only if `vendor` is `apple`" |
There was a problem hiding this comment.
is there a case where is_like_darwin is false but vendor is still Apple? out could we turn those into a function which compares the vendor?
There was a problem hiding this comment.
No such cases, no.
But it seems to me like all the other is_like_* fields should also be functions, then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
is_like_osxwithis_like_darwin, which more closely describes reality (OS X is the pre-2016 name for macOS, and is by now quite outdated; Darwin is the overall name for the OS underlying Apple's macOS, iOS, etc.).@rustbot label O-apple
r? compiler