Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk: Replace 'oxidize' with 'rustc'. Closes #13781 #14334

Merged
merged 1 commit into from
May 21, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented May 21, 2014

Using rustc instead of e.g. compile makes it clear this is a rust build step.

@lilyball
Copy link
Contributor

The end of an era.

@jfager
Copy link
Contributor

jfager commented May 21, 2014

This should close #13781, not #1378

@lilyball lilyball changed the title mk: Replace 'oxidize' with 'rustc'. Closes #1378 mk: Replace 'oxidize' with 'rustc'. Closes #13781 May 21, 2014
@lilyball
Copy link
Contributor

Good catch. I just updated the PR title but only @brson can fix the commit message.

bors added a commit that referenced this pull request May 21, 2014
Using `rustc` instead of e.g. `compile` makes it clear this is a rust build step.
@bors bors closed this May 21, 2014
@bors bors merged commit 7c8c544 into rust-lang:master May 21, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2023
feat: add `is_float` & `is_char` to `hir::Type`

Some useful functions we didn't have on `Type` (were present on `BuiltinType`).

Also, I am considering exposing `TyKind` with `get_kind`, let me know if that's a better idea than implementing these API extensions incrementally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants