libsyntax: Allow + to separate trait bounds from objects.
#14827
+179
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return (None, None); | ||
| } | ||
|
|
||
| -> (Option<ast::Lifetime>, Option<OwnedSlice<TyParamBound>>) { |
There was a problem hiding this comment.
It looks like this method may want to get renamed, and the second value of the tuple should be OwnedSlice instead of Option<OwnedSlice<...>>
|
The tests added here seem quite light. Can you add more tests dealing with the precedence of |
|
Could you also add |
|
re-r? @alexcrichton |
| // Next, parse a colon and bounded type parameters, if applicable. | ||
| // Next, parse a plus and bounded type parameters, if applicable. | ||
| // | ||
| // NOTE(pcwalton): Remove `token::COLON` after a snapshot. |
There was a problem hiding this comment.
I normally grep for the string stage0 as well, could you put that in the comment?
|
r=me with one minor comment |
RFC rust-lang#27. After a snapshot, the old syntax will be removed. This can break some code that looked like `foo as &Trait:Send`. Now you will need to write `foo as (&Trait+Send)`. Closes rust-lang#12778. [breaking-change]
|
I canceled the most recent build because this is contained within the rollup (trying to land that all at once) |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 19, 2023
…Veykril autopublish: Offset version number The workflow is currently failing because it's trying to publish 0.0.16, while the last version published was 0.0.149.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC #27; issue #12778.
After a snapshot, the old syntax will be removed.
This can break some code that looked like
foo as &Trait:Send. Now youwill need to write
foo as (&Trait+Send).[breaking-change]
r? @alexcrichton