Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librustc: offer suggestions for unresolved names. #5096

Closed
wants to merge 3 commits into from
Closed

librustc: offer suggestions for unresolved names. #5096

wants to merge 3 commits into from
+92 −11

Conversation

luqmana
Copy link
Member

@luqmana luqmana commented Feb 23, 2013

Address #2281

-> % cat foo.rs
fn foo() -> int {
    let bar = 10;

    bad
}

-> % rustc foo.rs
foo.rs:4:4: 4:7 error: unresolved name: `bad`. Did you mean: `bar`?
foo.rs:4     bad
             ^~~
error: aborting due to previous error

@bstrie
Copy link
Contributor

bstrie commented Feb 23, 2013

This looks really cool.

@jdm
Copy link
Contributor

jdm commented Feb 23, 2013

\o/

@luqmana
Copy link
Member Author

luqmana commented Feb 27, 2013

r? @catamorphism

bors added a commit that referenced this pull request Feb 27, 2013
@bors
auto merge of #5096 : luqmana/rust/spell, r=catamorphism
28b50a4 
Address #2281


```
-> % cat foo.rs
fn foo() -> int {
    let bar = 10;

    bad
}
```

```
-> % rustc foo.rs
foo.rs:4:4: 4:7 error: unresolved name: `bad`. Did you mean: `bar`?
foo.rs:4     bad
             ^~~
error: aborting due to previous error
```
@bors bors closed this Feb 27, 2013
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2020
@bors
Auto merge of rust-lang#5096 - eddyb:mac-name, r=oli-obk
b6a9766 
Don't use ExpnKind::descr to get the name of a bang macro.

This is the same change as the first commit in rust-lang#68407, but applied to clippy.
The new code should work both before and after the changes in rust-lang#68407.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@luqmana @bstrie @jdm @catamorphism @bors