Fix rib example #2199
Merged
Fix rib example #2199
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
reviewed
Jan 9, 2025
There was a problem hiding this comment.
This seems reasonable, but it'd be good to get a review from someone more experienced with the resolver. cc @petrochenkov maybe? (feel free to "reassign" of course)
jieyouxu
added
S-waiting-on-review
|
Ping @petrochenkov, if you have time, could you kindly double-check? |
petrochenkov
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way ribs were presented before one would assume
helperwould be available inside closure, but it's not:that's because ribs for let are introduced at the end of let statement and not while in expresions.
related zulip thread: https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Ribs.20in.20name.20resolution
It is possible that my understanding is wrong, so please correct me if I am wrong.