remove #[no_mangle] from panic handler #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change on rustc nightly broke panic handlers that also have the #[no_mangle] attribute. It looks like they don't consider this to be a bug. Let's just remove it.
Freax13
force-pushed
the
fix/panic-linker-error
branch
from
70fc315 to
050fde2
Compare
phil-opp
approved these changes
Mar 24, 2025
|
Thanks a lot for looking into this! |
|
Published as v0.9.31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change on rustc nightly broke panic handlers that also have the #[no_mangle] attribute.
I don't know whether this is something that they want to support and if they'll fix that, but either way I don't think there's a strong reason to keep this, so let's just remove it.It looks like they don't consider this to be a bug. Let's just remove it.Closes #499