Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a query where the user can exclude trophies based on title #276

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Include a query where the user can exclude trophies based on title #276

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2f3f13
First step to developing a feature to exclude speicifc trophies by title
a2ys Jun 18, 2024
130267a
Added support for exclusion by title
a2ys Jun 18, 2024
19f96e7
Ran deno lint, deno format and deno test found in CONTRIBUTING
a2ys Jun 18, 2024
bd71478
Merge branch 'ryo-ma:master' into master
a2ys Jul 3, 2024
0f15e5d
Documented the latest addition in the README
a2ys Jul 3, 2024
a119ea8
Updated README
a2ys Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added support for exclusion by title
  • Loading branch information
@a2ys
a2ys committed Jun 18, 2024
commit 130267a7124c1d7c29a6f1b5e6eb0c91ec52d58c
6 changes: 5 additions & 1 deletion src/card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ export class Card {
trophyList.filterByHidden();

if (this.titles.length != 0) {
trophyList.filterByTitles(this.titles);
const includeTitles = this.titles.filter(title => !title.startsWith("-"));
if (includeTitles.length > 0) {
trophyList.filterByTitles(includeTitles);
}
trophyList.filterByExclusionTitles(this.titles);
}

if (this.ranks.length != 0) {
Expand Down