Fix for #1 - Intercepts filenames on HtmlReporter to truncate if length > 255 #2
Conversation
…ritten is within 255 chars long. If not, will get the difference and remove the number of characters == difference from the baseName of the file
mAiNiNfEcTiOn
changed the title
mAiNiNfEcTiOn
changed the title
| fileWriter.writeFile = function writeFile(file, callback) { | ||
| if (file.length > 255) { | ||
| var excess = file.length - 255; | ||
| var baseName = path.basename(file, '.html') |
There was a problem hiding this comment.
I am not sure but does fileWriter write more than just html files?
There was a problem hiding this comment.
Yes, it also writes the base.css files from the report, png's etc (see screenshot below):
There was a problem hiding this comment.
But those normally don't hit the 255 chars length, but I can also use the path.extname().
Will do.
|
thx for the PR, comments left on the diff. |
|
Thanks for the comments. Do you see any more places where I can improve it? |
|
Also for a little bit more info: Before improvements:
After improvements:
I guess it's always good to know :) |
|
Looks great now much simpler :) thanks a ton @mAiNiNfEcTiOn 👏 |
|
My pleasure ;) |
|
Looks like #3 started happening due to this :) |
|
|
||
| fileWriter.writeFile = function writeFile(file, callback) { | ||
| var ext = path.extname(file); | ||
| file = file.slice(0, 255 - ext.length) + ext; |
There was a problem hiding this comment.
this + ext should only happen if the length was > 255
see #3
What does this PR do:
Basically adds an 'interceptor' that verifies if the filepath being written is within 255 chars long. If not, will get the difference and remove the number of characters == difference from the baseName of the file.
Fixes #1
Where should the reviewer start:
masterand with this PR.