Sourcery refactored main branch #1

sourcery-ai · 2023-05-12T06:12:36Z

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai

Due to GitHub API limits, only the first 60 comments can be shown.

sourcery-ai · 2023-05-12T06:12:38Z

setup.py

-    # Make sure to sync the versions of common dependencies (absl-py, numpy,
-    # six, and protobuf) with TF.


Lines 178-217 refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

This removes the following comments ( why? ):

# Make sure to sync the versions of common dependencies (absl-py, numpy, # six, and protobuf) with TF.

sourcery-ai · 2023-05-12T06:12:39Z

tensorflow_gnn/data/unigraph.py

-    raise ValueError("Could not guess file format for: {}".format(filename))
+    raise ValueError(f"Could not guess file format for: {filename}")


Function guess_file_format refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-05-12T06:12:39Z

tensorflow_gnn/data/unigraph.py

-  return match.group(1) if match else file_pattern
+  return match[1] if match else file_pattern


Function get_base_filename refactored with the following changes:

Replace m.group(x) with m[x] for re.Match objects (use-getitem-for-re-match-groups)

sourcery-ai · 2023-05-12T06:12:39Z

tensorflow_gnn/data/unigraph.py

-  match = re.fullmatch(r"(.*)@(\d+)", file_pattern)
-  if not match:
+  if match := re.fullmatch(r"(.*)@(\d+)", file_pattern):
+    return "{}-?????-of-{:05d}".format(match[1], int(match[2]))
+  else:
    return file_pattern
-  num_shards = int(match.group(2))
-  return "{}-?????-of-{:05d}".format(match.group(1), num_shards)


Function expand_sharded_pattern refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Lift code into else after jump in control flow (reintroduce-else)

Swap if/else branches (swap-if-else-branches)

Inline variable that is only used once (inline-variable)

Replace m.group(x) with m[x] for re.Match objects [×2] (use-getitem-for-re-match-groups)

sourcery-ai · 2023-05-12T06:12:39Z

tensorflow_gnn/data/unigraph.py

-  # TODO(blais): Eventually support file suffixes.
-  match = re.fullmatch(r"(.*)@(\d+)", pattern)
-  if match:
+  if match := re.fullmatch(r"(.*)@(\d+)", pattern):
    # Beam would unpack automatically for internal containers, but we need this
    # for the open source implementation of the Beam runner.
-    return dict(file_path_prefix=match.group(1),
-                num_shards=int(match.group(2)),
-                shard_name_template="-SSSSS-of-NNNNN")
+    return dict(
+        file_path_prefix=match[1],
+        num_shards=int(match[2]),
+        shard_name_template="-SSSSS-of-NNNNN",
+    )
+  if match := re.fullmatch(r"(.*)-(?:\d|\?){5}-of-(\d{5})", pattern):
+    return dict(
+        file_path_prefix=match[1],
+        num_shards=int(match[2]),
+        shard_name_template="-SSSSS-of-NNNNN",
+    )
  else:
-    match = re.fullmatch(r"(.*)-(?:\d|\?){5}-of-(\d{5})", pattern)
-    if match:
-      return dict(file_path_prefix=match.group(1),
-                  num_shards=int(match.group(2)),
-                  shard_name_template="-SSSSS-of-NNNNN")
-    else:
-      return dict(file_path_prefix=pattern,
-                  num_shards=None, shard_name_template="")
+    return dict(file_path_prefix=pattern,
+                num_shards=None, shard_name_template="")


Function get_sharded_pattern_args refactored with the following changes:

Use named expression to simplify assignment and conditional [×2] (use-named-expression)

Replace m.group(x) with m[x] for re.Match objects [×4] (use-getitem-for-re-match-groups)

Remove unnecessary else after guard condition (remove-unnecessary-else)

This removes the following comments ( why? ):

# TODO(blais): Eventually support file suffixes.

sourcery-ai · 2023-05-12T06:12:41Z

tensorflow_gnn/graph/graph_tensor.py

-    node_sets_spec = _ifnone(node_sets_spec, dict())
-    edge_sets_spec = _ifnone(edge_sets_spec, dict())
+    node_sets_spec = _ifnone(node_sets_spec, {})
+    edge_sets_spec = _ifnone(edge_sets_spec, {})


Function GraphTensorSpec.from_piece_specs refactored with the following changes:

Replace dict() with {} [×2] (dict-literal)

sourcery-ai · 2023-05-12T06:12:41Z

tensorflow_gnn/graph/graph_tensor.py

-  if node_sets:
-    return first_by_name(node_sets)
-  return context
+  return first_by_name(node_sets) if node_sets else context


Function _get_indicative_graph_entity refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-05-12T06:12:41Z

tensorflow_gnn/graph/graph_tensor.py

-    if isinstance(data, Mapping):
-      self._data = data
-    else:
-      self._data = dict(data)
+    self._data = data if isinstance(data, Mapping) else dict(data)


Function _ImmutableMapping.__init__ refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-05-12T06:12:41Z

tensorflow_gnn/graph/graph_tensor_io.py

-  result.update(
-      _flatten_graph_field_specs(graph_spec.context_spec,
-                                 f'{prefix}{gc.CONTEXT}/'))
+  result |= _flatten_graph_field_specs(graph_spec.context_spec,
+                                       f'{prefix}{gc.CONTEXT}/')


Function _ refactored with the following changes:

Merge dictionary updates via the union operator (dict-assign-update-to-union)

sourcery-ai · 2023-05-12T06:12:42Z

tensorflow_gnn/graph/graph_tensor_io.py

-  result.update(_prefix_keys(node_set_spec.features_spec, prefix))
+  result |= _prefix_keys(node_set_spec.features_spec, prefix)


Function _ refactored with the following changes:

Merge dictionary updates via the union operator (dict-assign-update-to-union)

sonarcloud · 2023-05-12T06:13:12Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

This is work-in-progress PiperOrigin-RevId: 491067724

sibonli and others added 2 commits November 17, 2021 20:00

Add API docs

bcc256d

'Refactored by Sourcery'

7a6b757

sourcery-ai bot requested a review from sarvex May 12, 2023 06:12

sourcery-ai bot commented May 12, 2023

View reviewed changes

sarvex pushed a commit that referenced this pull request May 30, 2023

Code Tutorial #1: Running TF-GNN on single machine.

f5c88f4

This is work-in-progress PiperOrigin-RevId: 491067724

sarvex force-pushed the main branch from bcc256d to dda17cb Compare May 30, 2023 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery refactored main branch #1

Sourcery refactored main branch #1

sourcery-ai bot commented May 12, 2023

sourcery-ai bot left a comment

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sourcery-ai bot May 12, 2023

sonarcloud bot commented May 12, 2023

		# Make sure to sync the versions of common dependencies (absl-py, numpy,
		# six, and protobuf) with TF.

		raise ValueError("Could not guess file format for: {}".format(filename))
		raise ValueError(f"Could not guess file format for: {filename}")

		return match.group(1) if match else file_pattern
		return match[1] if match else file_pattern

		result.update(_prefix_keys(node_set_spec.features_spec, prefix))
		result \|= _prefix_keys(node_set_spec.features_spec, prefix)

Sourcery refactored main branch #1

Are you sure you want to change the base?

Sourcery refactored main branch #1

Conversation

sourcery-ai bot commented May 12, 2023

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sourcery-ai bot May 12, 2023

Choose a reason for hiding this comment

sonarcloud bot commented May 12, 2023