Adding main tag to reset, as was added to spec after reset written #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally think this is a nice addition. Not sure I want to lose the "unmodified" badge as I think that's a primary reason people choose this package over other modified resets. If @meyerweb officially endorsed this change, it would be a no brainer. In the meantime, please bear with me as I give it some thought. Thanks, @scoobster17. |
|
It’s probably time I revisited the reset to make sure it’s HTML5-happy. Basically, I need to go through https://www.w3.org/TR/html5/index.html#elements-1 and make sure I’m up to date. So this is something I do/will endorse, the latter by making the change to the base reset. |
|
Thank you, @meyerweb! Looking forward to the update. |
|
Released as v2.0.20160720. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I appreciate this project is an untouched version of the reset.
I have used this reset on pretty much every project I have made. But I recently thought it would be good to include as npm/bower dependency and found this project, but more importantly import using Sass.
As per a post I made a couple of years ago (link below), I have found issues whereby when the MAIN tag was added to the HTML5 spec after it's initial release, this was after the reset was written.
I believe had it been around, this would have been included in the reset by @meyerweb. That is why I have submitted this pull request.
https://scoobster17.wordpress.com/2014/04/23/eric-meyer-reset-missing-style-for-html5-main-element/