Skip to content

Commit

Permalink
Cmwilson21 patch 1 (#4)
Browse files Browse the repository at this point in the history
* Update -step.txt

* Update and rename 1-enable-codeql.ml to 1-enable-codeql.yml

* Update 2-review-and-triage-codeql-alerts.yml

* Update 3-fix-security-vulnerabilities.yml

* Update 4-prevent-vulnerabilities-in-the-pull-request.yml

* Update 4-prevent-vulnerabilities-in-the-pull-request.yml

* Update 1-enable-codeql.md

* Update 0-welcome.yml
  • Loading branch information
cmwilson21 authored Oct 19, 2023
1 parent 34a37f6 commit ce8ca8f
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/steps/-step.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1
0
1 change: 0 additions & 1 deletion .github/steps/1-enable-codeql.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ First, we will enable code scanning with CodeQL in our repository.
3. Under the **Security** section on the left side, select **Code security and analysis**.
4. Scroll down to the section titled **Code scanning**. For the purpose of this course, we will focus on CodeQL analysis.
5. Click on the **Set up** dropdown menu and choose **Default**.
6.
![enable-code-scanning-default.png](/images/enable-code-scanning-default.png)

Let's take a look at the configuration options in the modal:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
lname: Step 1, Enable CodeQL
name: Step 1, Enable CodeQL

# This step triggers after enabling codeql.
# This workflow updates from step 1 to step 2.
Expand All @@ -8,7 +8,10 @@ lname: Step 1, Enable CodeQL
on:
workflow_dispatch:
# Add events that trigger this workflow.
# enable-codeql-event:
workflow_run:
workflows: [CodeQL]
types:
- in_progress

# Reference: https://docs.github.com/en/actions/security-guides/automatic-token-authentication
permissions:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/2-review-and-triage-codeql-alerts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ name: Step 2, review-and-triage-codeql-alerts
on:
workflow_dispatch:
# Add events that trigger this workflow.
# review-and-triage-codeql-alerts-event:
issues:
types: [opened]

# Reference: https://docs.github.com/en/actions/security-guides/automatic-token-authentication
permissions:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/3-fix-security-vulnerabilities.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ name: Step 3, fix-security-vulnerabilities
on:
workflow_dispatch:
# Add events that trigger this workflow.
# fix-security-vulnerabilities-event:
push:
paths:
- server/routes.py

# Reference: https://docs.github.com/en/actions/security-guides/automatic-token-authentication
permissions:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ name: Step 4, prevent-vulnerabilities-in-the-pull-request
on:
workflow_dispatch:
# Add events that trigger this workflow
# prevent-vulnerabilities-in-the-pull-request-event:
pull_request:
types: opened

# Reference: https://docs.github.com/en/actions/security-guides/automatic-token-authentication
permissions:
Expand Down Expand Up @@ -61,5 +62,5 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
from_step: 4
to_step: 5
to_step: X
branch_name: tbd-branch-name

0 comments on commit ce8ca8f

Please sign in to comment.