-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learn module refresh -- Build continuous integration (CI) workflows by using GitHub Actions #51
Conversation
slight edits per the style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamAntonRohm Thanks for submitting this PR! I agree, this helps refresh the language quite a bit. We are currently in the process of updating the content of each Skills course as we can. I've committed a few edits to your suggestions per our style guide (Select
vs Click
for buttons and other descriptions found here in the style guide).
I'll get this merged! Thanks again for taking the time to provide this update 💖
``` | ||
```markdown | ||
_underscore_ | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent worsened
|
||
First, let's add a workflow to lint our Markdown files in this repository. | ||
First, let's add a workflow to *lint* (clean, like a lint roller) our Markdown files in this repository. This workflow has a deliberate error in it ("npx" should be "npm"), which we'll debug in the next unit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamAntonRohm
The deliberate error has nothing to do with the use of "npx" instead of "npm". What do you mean by '("npx" should be "npm")'? Also, why did you use single asterisks (*lint*
) in this markdown file? This will induce another error. In #25, a special markdown file (not for steps) is created that contains the deliberate error.
Moreover, what's the next unit? Skills courses are not Microsoft Learn modules.
Resolve stylistic errors in the step markdown files
* Clean up the mess made in #51 Resolve stylistic errors in the step markdown files * Activate `action-update-step` in Steps 4 and 5 Uncomment the steps * Change instructions corresponding to workflows Tell learners to follow instructions on `ci` * Insert "and" before "then" * Refer to the merge conflicts TODO: figure out a better way * Resolve the **Review required** merge block You don't want to bypass branch protections
This pull request is the child of https://github.com/MicrosoftDocs/learn-pr/pull/39680
Work item: AB#916441
Module URL: https://learn.microsoft.com/en-us/training/modules/github-actions-ci