Cannot set name on Card

[Flo354]

Hi there,

Since I updated my SDK version from 8.X to 9.3.2, the method setName() on Card class does not exists anymore. Since the card is built with CardMultilineWidget, I can't set the name anymore.

How can I set the cardholder name without having to create an other instance of Card and set name in the builder?

Before:

CardMultilineWidget cardInputWidget = v.findViewById(R.id.card_input_widget);
//....

Card card = cardInputWidget.getCard()));
card.setName(cardHolderName);

Now:

CardMultilineWidget cardInputWidget = v.findViewById(R.id.card_input_widget);
//....

Card card = cardInputWidget.getCard()));
card = new Card.Builder(card.getNumber(), card.getExpMonth(), card.getExpYear(), card.getCVC())
                .name(name.getText().toString())
                .build();

Thanks,

[mshafrir-stripe]

@Flo354 sorry for the inconvenience caused by removing the setter. I put up a PR (#1108) that adds a Card#toBuilder() convenience method which you can use to add the name field.

[mshafrir]

@Flo354 this is now available in 9.3.5

[Flo354]

Thanks for the update.

But one question, why don't you allow us to add the name instead of creating another object?
I am using the multiline widget and it gives a card (method getCard()). Why don't you give us a builder instead? It would avoid the creation of an object.

[mshafrir-stripe]

@Flo354 we're using immutable models where possible, but an alternative option would be to add a getCardBuilder() method to the widget so you can start with a Builder.

[Flo354]

Thanks for your answer. It would be great indeed. So we don't have to create multiple objects... I don't think that recreating such an object is expansive, but it's better. Will you create this method in a next release? Thanks,

…

On Thu, Jul 11, 2019 at 3:23 PM Michael Shafrir ***@***.***> wrote: @Flo354 <https://github.com/Flo354> we're using immutable models where possible, but an alternative option would be to add a getCardBuilder() method to the widget so you can start with a Builder. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1106?email_source=notifications&email_token=ABANNX455KDA2TPUOMCPOSLP64X3NA5CNFSM4HXXHQG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZWVWLQ#issuecomment-510483246>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABANNXYKHJMIXAT5VO3WBTTP64X3NANCNFSM4HXXHQGQ> .

[mshafrir-stripe]

@Flo354 I added a getCardBuilder() method to the widgets in #1174

[Flo354]

Thanks! Le ven. 12 juil. 2019 à 6:53 AM, Michael Shafrir <[email protected]> a écrit :

…

@Flo354 <https://github.com/Flo354> I added a getCardBuilder() method to the widgets in #1174 <#1174> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1106?email_source=notifications&email_token=ABANNXYDOIBI5CMAOMNJ6HLP7AE4JA5CNFSM4HXXHQG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZYVL4I#issuecomment-510744049>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABANNX2XO2G5INLNHSRKHBTP7AE4JANCNFSM4HXXHQGQ> .