Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert CustomizableShippingField to enum #2617

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Convert CustomizableShippingField to enum #2617

merged 1 commit into from
Jul 7, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

Summary

  • setOptionalFields() is now optionalFields
  • setHiddenFields() is now hiddenFields
  • CustomizableShippingField is now an enum

Motivation

Consistency

Testing

@mshafrir-stripe mshafrir-stripe merged commit f099c4a into master Jul 7, 2020
@mshafrir-stripe mshafrir-stripe deleted the shipping-enum branch July 7, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaskell-stripe smaskell-stripe smaskell-stripe approved these changes

Assignees

@mshafrir-stripe mshafrir-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshafrir-stripe @smaskell-stripe @chander-stripe