Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AfterpayClearpay PaymentMethodCreateParams public #3302

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Make AfterpayClearpay PaymentMethodCreateParams public #3302

merged 2 commits into from
Jan 27, 2021

Conversation

aliriaz-stripe
Copy link
Contributor

Summary

removed internal from createAfterpayClearpay() function

Testing

Ran tests

mshafrir-stripe
mshafrir-stripe requested changes Jan 27, 2021
View reviewed changes
stripe/src/main/java/com/stripe/android/model/PaymentMethodCreateParams.kt Outdated
@@ -713,7 +713,7 @@ data class PaymentMethodCreateParams internal constructor(

@JvmSynthetic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to @JvmStatic so that it's accessible from Java.

@aliriaz-stripe
Copy link
Contributor Author

@mshafrir PTAL

@aliriaz-stripe aliriaz-stripe merged commit 966efb8 into master Jan 27, 2021
@aliriaz-stripe aliriaz-stripe deleted the aliriaz/afterpay-public branch January 27, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshafrir-stripe mshafrir-stripe mshafrir-stripe approved these changes

Assignees

@aliriaz-stripe aliriaz-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliriaz-stripe @mshafrir-stripe