Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine PaymentAuthWebViewClient completion URL logic #3548

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Refine PaymentAuthWebViewClient completion URL logic #3548

merged 2 commits into from
Apr 1, 2021

Conversation

mshafrir-stripe
Copy link
Collaborator

Summary

Generalize completion URL matching logic. This is a follow-up to #3543.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

@mshafrir-stripe
Refine PaymentAuthWebViewClient completion URL logic
8806f17 
Generalize URL matching logic. This is a follow-up to #3543.
michelleb-stripe
michelleb-stripe approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@michelleb-stripe michelleb-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@mshafrir-stripe mshafrir-stripe merged commit b501ff3 into master Apr 1, 2021
@mshafrir-stripe mshafrir-stripe deleted the 3ds1-completion-url branch April 1, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelleb-stripe michelleb-stripe michelleb-stripe approved these changes

@ccen-stripe ccen-stripe Awaiting requested review from ccen-stripe

@btidor-stripe btidor-stripe Awaiting requested review from btidor-stripe

Assignees

@aliriaz-stripe aliriaz-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshafrir-stripe @michelleb-stripe @aliriaz-stripe