Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Add support for http logoUri #4851

Merged
merged 3 commits into from
Apr 8, 2022
Merged

[Identity] Add support for http logoUri #4851

merged 3 commits into from
Apr 8, 2022

Conversation

ccen-stripe
Copy link
Contributor

@ccen-stripe ccen-stripe commented Apr 8, 2022

Summary

Support loading Uri from "http://"

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

  • [Fixed] Fix the crash when an http:// link is passed for logo Uri

package="com.stripe.android.identity">

<uses-permission android:name="android.permission.CAMERA" />

<application>
<application
android:usesCleartextTraffic="true"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag is required for accessing http:// links over api version m

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │          uncompressed          
          ├──────────┬──────────┬────────┼───────────┬───────────┬────────
 APK      │ old      │ new      │ diff   │ old       │ new       │ diff   
──────────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
      dex │ 13.2 MiB │ 13.2 MiB │ -267 B │  44.1 MiB │  44.1 MiB │ -204 B 
     arsc │  1.6 MiB │  1.6 MiB │    0 B │   1.6 MiB │   1.6 MiB │    0 B 
 manifest │  2.9 KiB │  2.9 KiB │    0 B │  12.3 KiB │  12.3 KiB │    0 B 
      res │  762 KiB │  762 KiB │    0 B │   1.2 MiB │   1.2 MiB │    0 B 
    asset │ 79.4 KiB │ 79.4 KiB │   +3 B │ 108.9 KiB │ 108.9 KiB │   +3 B 
    other │ 80.3 KiB │ 80.3 KiB │    0 B │ 154.9 KiB │ 154.9 KiB │    0 B 
──────────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
    total │ 15.7 MiB │ 15.7 MiB │ -264 B │  47.2 MiB │  47.2 MiB │ -201 B 

         │          raw           │            unique             
         ├────────┬────────┬──────┼────────┬────────┬─────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff        
─────────┼────────┼────────┼──────┼────────┼────────┼─────────────
   files │      3 │      3 │    0 │        │        │             
 strings │ 213068 │ 213067 │   -1 │ 187895 │ 187895 │  0 (+2 -2)  
   types │  36803 │  36803 │    0 │  34216 │  34216 │  0 (+0 -0)  
 classes │  31642 │  31642 │    0 │  31642 │  31642 │  0 (+0 -0)  
 methods │ 189730 │ 189718 │  -12 │ 183806 │ 183800 │ -6 (+4 -10) 
  fields │ 128876 │ 128876 │    0 │ 128049 │ 128049 │  0 (+1 -1)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  293 │  293 │  0   
 entries │ 5597 │ 5597 │  0
APK
    compressed    │   uncompressed   │                               
─────────┬────────┼─────────┬────────┤                               
 size    │ diff   │ size    │ diff   │ path                          
─────────┼────────┼─────────┼────────┼───────────────────────────────
 3.2 MiB │ -267 B │ 8.7 MiB │ -204 B │ ∆ classes2.dex                
 7.6 KiB │   +3 B │ 7.4 KiB │   +3 B │ ∆ assets/dexopt/baseline.prof 
─────────┼────────┼─────────┼────────┼───────────────────────────────
 3.2 MiB │ -264 B │ 8.7 MiB │ -201 B │ (total)
DEX
STRINGS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   187895 │ 187895 │ 0 (+2 -2) 
  + (Ljava/net/HttpURLConnection;)V
  + (Ljava/net/HttpURLConnection;Ljava/io/File;)V
  
  - (Ljavax/net/ssl/HttpsURLConnection;)V
  - (Ljavax/net/ssl/HttpsURLConnection;Ljava/io/File;)V
  

METHODS:

   old    │ new    │ diff        
  ────────┼────────┼─────────────
   183806 │ 183800 │ -6 (+4 -10) 
  + com.stripe.android.core.networking.ConnectionFactory_Default openConnectionAndApplyFields(StripeRequest) → HttpURLConnection
  + com.stripe.android.core.networking.StripeConnection_AbstractConnection <init>(HttpURLConnection)
  + com.stripe.android.core.networking.StripeConnection_Default <init>(HttpURLConnection)
  + com.stripe.android.core.networking.StripeConnection_FileConnection <init>(HttpURLConnection, File)
  
  - com.stripe.android.core.networking.ConnectionFactory_Default openConnectionAndApplyFields(StripeRequest) → HttpsURLConnection
  - com.stripe.android.core.networking.StripeConnection_AbstractConnection <init>(HttpsURLConnection)
  - com.stripe.android.core.networking.StripeConnection_Default <init>(HttpsURLConnection)
  - com.stripe.android.core.networking.StripeConnection_FileConnection <init>(HttpsURLConnection, File)
  - javax.net.ssl.HttpsURLConnection getErrorStream() → InputStream
  - javax.net.ssl.HttpsURLConnection getHeaderFields() → Map
  - javax.net.ssl.HttpsURLConnection getInputStream() → InputStream
  - javax.net.ssl.HttpsURLConnection setConnectTimeout(int)
  - javax.net.ssl.HttpsURLConnection setReadTimeout(int)
  - javax.net.ssl.HttpsURLConnection setUseCaches(boolean)
  

FIELDS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   128049 │ 128049 │ 0 (+1 -1) 
  + com.stripe.android.core.networking.StripeConnection_AbstractConnection conn: HttpURLConnection
  
  - com.stripe.android.core.networking.StripeConnection_AbstractConnection conn: HttpsURLConnection

Base automatically changed from ccen/loadHttp to master April 8, 2022 22:31
@ccen-stripe ccen-stripe merged commit 435facb into master Apr 8, 2022
@ccen-stripe ccen-stripe deleted the ccen/loadHttp2 branch April 8, 2022 22:32
jaynewstrom-stripe added a commit that referenced this pull request Jun 25, 2024
jaynewstrom-stripe added a commit that referenced this pull request Jun 25, 2024
This is more or less a manual revert of #4851.
jaynewstrom-stripe added a commit that referenced this pull request Jun 25, 2024
jaynewstrom-stripe added a commit that referenced this pull request Jun 25, 2024
This is more or less a manual revert of #4851.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants