Fix payment cancellation on back press during processing #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
requested review from
jaynewstrom-stripe,
tillh-stripe,
ccen-stripe,
awush-stripe and
carlosmuvi-stripe
as code owners
jameswoo-stripe
force-pushed
the
jameswoo/5844-fix-paymentsheet-onback
branch
from
a98001e
to
00aca28
Compare
...om/stripe/android/paymentsheet/example/playground/activity/PaymentSheetPlaygroundActivity.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetActivity.kt
Outdated
Show resolved
Hide resolved
jameswoo-stripe
force-pushed
the
jameswoo/5844-fix-paymentsheet-onback
branch
from
00aca28
to
a41d55d
Compare
jameswoo-stripe
force-pushed
the
jameswoo/5844-fix-paymentsheet-onback
branch
from
a41d55d
to
4b684ba
Compare
jaynewstrom-stripe
previously approved these changes
Nov 18, 2022
|
Is it possible to write a test for this? |
Co-authored-by: Till Hellmund <[email protected]>
jaynewstrom-stripe
approved these changes
Nov 18, 2022
Dayday10
suggested changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where payment gets cancelled on back press during processing in PaymentSheet.
Motivation
Fixes #5844
Testing
Changelog
BaseSheetActivityto prevent them from incorrectly being displayed as canceled.