Fix memory leaks in example app #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemerick-stripe
approved these changes
Apr 11, 2019
samplestore/src/main/java/com/stripe/samplestore/PaymentActivity.java
Outdated
Show resolved
Hide resolved
mshafrir-stripe
changed the base branch from
activity-payment-session-listener
to
master
**Summary** - Create `ActivitySourceCallback` to help with memory handling - Refactor and clean-up classes in example app to fix memory leaks as identified by LeakCanary - Call `CompositeSubscription#unsubscribe()` in `Activity#onDestroy()` where missing **Motivation** ANDROID-349 **Testing** Ran example app
mshafrir-stripe
force-pushed
the
stripe-callbacks
branch
from
909751d
to
c9150d4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActivitySourceCallbackto help with memoryhandling
memory leaks as identified by LeakCanary
CompositeSubscription#unsubscribe()inActivity#onDestroy()where missingMotivation
ANDROID-349
Testing
Tested on example app