Skip to content
/ symfony-docs Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][Routing] Added the Route attribute #14188

Closed
fabpot opened this issue Sep 7, 2020 · 2 comments · Fixed by #14230
Closed

[RFC][Routing] Added the Route attribute #14188

fabpot opened this issue Sep 7, 2020 · 2 comments · Fixed by #14230
Labels
hasPR A Pull Request has already been submitted for this issue. Routing
Milestone
5.2

Comments

@fabpot
Copy link
Member

fabpot commented Sep 7, 2020

Q A
Feature PR symfony/symfony#37474
PR author(s) @derrabus
Merged in 5.2-dev
@derrabus
Copy link
Member

derrabus commented Sep 7, 2020

Added to my TODO list. 👍

@xabbuh xabbuh added the Routing label Sep 10, 2020
@xabbuh xabbuh added this to the 5.2 milestone Sep 10, 2020
@derrabus derrabus mentioned this issue Sep 11, 2020
Merged
fabpot added a commit to fabpot/sphinx-php that referenced this issue Sep 12, 2020
@fabpot
feature #49 Support for "php-attributes" code blocks (derrabus)
0dd00a1 
This PR was merged into the 2.0-dev branch.

Discussion
----------

Support for "php-attributes" code blocks

For my work on symfony/symfony-docs#14188, I need a way to express configuration samples with PHP attributes.

For instance, I'd like to add a tab "Attributes" to the code blocks on this page: https://symfony.com/doc/current/routing.html#matching-http-methods. The change proposed with this PR enables me to do that.

Commits
-------

9d64df4 Support for "php-attributes" code blocks
@derrabus derrabus mentioned this issue Sep 12, 2020
Merged
@derrabus
Copy link
Member

I've opened #14230.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Routing
Projects
None yet
Milestone
5.2
Development

Successfully merging a pull request may close this issue.

[Routing] Document the Route attribute derrabus/symfony-docs
3 participants
@fabpot @derrabus @xabbuh