[PhpUnitBridge] Polyfill new phpunit 9.1 assertions #37567
Merged
+118
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 13, 2020
fabpot
approved these changes
Jul 15, 2020
fabpot
force-pushed
the
phpfour-polyfill-new-phpunit-91-assertions
branch
from
3765154 to
51c0bf0
Compare
|
Thank you @phpfour. |
fabpot
added a commit
that referenced
this pull request
Aug 28, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Polyfill new phpunit 9.1 assertions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37320 | License | MIT | Doc PR | - Backport of #37567, follows the discussion on #37960. Commits ------- d945b88 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following new assertions that was added to PhpUnit 9.1:
assertIsNotReadable()as alternative forassertNotIsReadable()assertIsNotWritable()as alternative forassertNotIsWritable()assertDirectoryDoesNotExist()as alternative forassertDirectoryNotExists()assertDirectoryIsNotReadable()as alternative forassertDirectoryNotIsReadable()assertDirectoryIsNotWritable()as alternative forassertDirectoryNotIsWritable()assertFileDoesNotExist()as alternative forassertFileNotExists()assertFileIsNotReadable()as alternative forassertFileNotIsReadable()assertFileIsNotWritable()as alternative forassertFileNotIsWritable()assertMatchesRegularExpression()as alternative forassertRegExp()assertDoesNotMatchRegularExpression()as alternative forassertNotRegExp()