Skip to content

[Translation] deal with indented heredoc/nowdoc tokens #40318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 26, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40278
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Feb 26, 2021
@carsonbot carsonbot changed the title [Translator] deal with indented heredoc/nowdoc tokens [Translation] deal with indented heredoc/nowdoc tokens Feb 26, 2021
@rmdefi
Copy link

rmdefi commented Feb 26, 2021

Thank you.

If I understand correctly, this only accept spaces for indentation.
Could this be modified to also accept tabulations?

@fabpot
Copy link
Member

fabpot commented Mar 4, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit 218bf5e into symfony:4.4 Mar 4, 2021
This was referenced Mar 4, 2021
@xabbuh xabbuh deleted the issue-40278 branch March 4, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants