Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macos): do not emit ThemeChanged event if window theme didn't change #430

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix(macos): do not emit ThemeChanged event if window theme didn't change #430

merged 1 commit into from
Jun 20, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested review from a team June 19, 2022 16:34
@lucasfernog lucasfernog requested a review from a team as a code owner June 19, 2022 16:34
keiya01
keiya01 approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@keiya01 keiya01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@wusyong wusyong merged commit aae6bec into dev Jun 20, 2022
@wusyong wusyong deleted the fix/theme-changed-event branch June 20, 2022 10:46
@github-actions github-actions bot mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiya01 keiya01 keiya01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfernog @keiya01 @wusyong