Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose Manager::resources_table #8276

Merged
merged 8 commits into from
Nov 21, 2023
Merged

feat: expose Manager::resources_table #8276

merged 8 commits into from
Nov 21, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Nov 21, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner November 21, 2023 00:05
@lucasfernog lucasfernog merged commit bf095df into dev Nov 21, 2023
3 checks passed
@lucasfernog lucasfernog deleted the feat/expose-resources_table branch November 21, 2023 10:57
amrbashir added a commit that referenced this pull request Dec 11, 2023
@amrbashir
feat(api): expose Resource class
c825a3a 
continuation of #8276
@amrbashir amrbashir mentioned this pull request Dec 11, 2023
Merged
13 tasks
lucasfernog added a commit that referenced this pull request Dec 18, 2023
@amrbashir @lucasfernog
feat(api): expose Resource class (#8370)
428ea65 
* feat(api): expose `Resource` class

continuation of #8276

* Apply suggestions from code review

* fmt

---------

Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog