Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler): migrate WebView2 offline installer to shorturl #8292

Merged
merged 22 commits into from
Nov 29, 2023
Merged

fix(bundler): migrate WebView2 offline installer to shorturl #8292

merged 22 commits into from
Nov 29, 2023

Conversation

i-c-b
Copy link
Contributor

@i-c-b i-c-b commented Nov 23, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@i-c-b i-c-b requested a review from a team as a code owner November 23, 2023 05:12
@i-c-b i-c-b changed the title fix(bundler): WebView2 offline installer GUID changes fix(bundler): migrate WebView2 offline installer to shorturl Nov 23, 2023
@i-c-b i-c-b marked this pull request as draft November 23, 2023 06:04
@i-c-b i-c-b marked this pull request as ready for review November 23, 2023 08:17
@i-c-b i-c-b requested a review from amrbashir November 24, 2023 03:02
@i-c-b i-c-b requested a review from amrbashir November 28, 2023 02:28
amrbashir
amrbashir requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for requesting a lot of changes but I think we are close to merge this

tooling/bundler/src/bundle/windows/nsis.rs Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/nsis.rs Outdated Show resolved Hide resolved
amrbashir
amrbashir requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for requesting a lot of changes but I think we are close to merge this

@i-c-b i-c-b requested a review from amrbashir November 29, 2023 01:28
amrbashir
amrbashir approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now

@amrbashir amrbashir merged commit 977a39f into tauri-apps:1.x Nov 29, 2023
10 checks passed
@i-c-b i-c-b deleted the webview2-offline-installer-guid branch November 29, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-c-b @amrbashir