Put codegen output into OUT_DIR rather than src/
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current guidance of putting code generated by a
build.rsscript intosrc/is generally not a good idea (see here). It leads to it being checked into source control and people trying to make edits to it.Trying to put the current output of
codegenintoOUT_DIRcauses errors to do with inner attributes not being permitted. This PR implements a config parameterclippy_attributeswhich turns off generating these attributes by default. They are turned back on for the CLI as it is assumed the user will be placing the output intosrc/in that case.Also see
prost_buildfor a good template for how code generation from an interface format should work.