Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Added README to base-template and tweaked chunked list advice #22

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

camerons
Copy link
Member

Purpose / why

  • README added based on feedback that it wasn't clear where to start with templates.
  • chunked list advice is review of aidantwork

Verification

  • Read new text, confirm it improves our story.
  • This is not addressing an issue as I'm not using issues in the incubator during this development phase.

Checklist

Pull-request reviewer should ensure the following

  • Are issues linked correctly?
  • Is this PR labeled correctly?
  • If template updates: do they align with developers.google.com/style/?
  • Did the PR receive at least one 👍 and no 👎 from core-maintainers?
  • On merging, did you complete the merge using keywords?
  • On merging, did you add any applicable notes to a draft release and link to this PR?

Copy link
Contributor

@aidanatwork aidanatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camerons, I made a couple minor suggestions for changes, for improved readability.

@camerons camerons merged commit aedd3b7 into master Feb 15, 2021
@camerons camerons deleted the camerons-base-template2 branch February 15, 2021 06:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants