Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested namespaces in Iceberg REST catalog #23453

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add support for nested namespaces in Iceberg REST catalog #23453

merged 1 commit into from
Oct 21, 2024
+303 −14

Conversation

sftwrdvlpr
Copy link
Contributor

@sftwrdvlpr sftwrdvlpr commented Sep 17, 2024 •
edited by ebyhr
Loading

Description

Fixes #22916

Release notes

# Iceberg
* Add support for nested namespaces in REST catalog. ({issue}`22916`)

@cla-bot cla-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the iceberg Iceberg connector label Sep 17, 2024
@ebyhr ebyhr self-requested a review September 17, 2024 07:59
@anusudarsan anusudarsan mentioned this pull request Sep 17, 2024
Closed
@anusudarsan anusudarsan self-requested a review September 17, 2024 17:51
@cla-bot cla-bot

This comment was marked as outdated.

Sign in to view
2 similar comments
@cla-bot cla-bot

This comment was marked as outdated.

Sign in to view
@cla-bot cla-bot

This comment was marked as outdated.

Sign in to view
mayankvadariya
mayankvadariya reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mayankvadariya mayankvadariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

...n/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestTrinoRestCatalog.java Outdated Show resolved Hide resolved
...n/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestTrinoRestCatalog.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoRestCatalog.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoRestCatalog.java Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoRestCatalog.java Show resolved Hide resolved
...n/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestTrinoRestCatalog.java Outdated Show resolved Hide resolved
@ebyhr
Copy link
Member

ebyhr commented Sep 26, 2024

@sftwrdvlpr Is this ready for review? Please rename the title and change the draft status if so.

@sftwrdvlpr sftwrdvlpr changed the title [WIP] Multipart namespaces support (Nessie and Rest catalogs) Multipart namespaces support (Nessie and Rest catalogs) Sep 28, 2024
@sftwrdvlpr sftwrdvlpr marked this pull request as ready for review September 28, 2024 01:33
@sftwrdvlpr sftwrdvlpr force-pushed the issue-22916 branch 2 times, most recently from 173c66d to ecd9e1d Compare September 30, 2024 15:09
@sftwrdvlpr

This comment was marked as outdated.

Sign in to view
ebyhr

This comment was marked as resolved.

Sign in to view

@sftwrdvlpr

This comment was marked as outdated.

Sign in to view
@ebyhr

This comment was marked as resolved.

Sign in to view
@sftwrdvlpr
Copy link
Contributor Author

@ebyhr yes, I'll discuss this with @mayankvadariya, thanks.

@findepi findepi changed the title Multipart namespaces support (Nessie and Rest catalogs) Nested namespaces support (Nessie and Rest catalogs) Oct 2, 2024
@sftwrdvlpr sftwrdvlpr changed the title Nested namespaces support (Nessie and Rest catalogs) Nested namespaces support for Rest catalog Oct 2, 2024
@ebyhr
Copy link
Member

ebyhr commented Oct 2, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 2, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 2, 2024

The cla-bot has been summoned, and re-checked this pull request!

ebyhr
ebyhr reviewed Oct 7, 2024
View reviewed changes
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
...ino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/IcebergRestCatalogConfig.java Outdated Show resolved Hide resolved
...ino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/IcebergRestCatalogConfig.java Outdated Show resolved Hide resolved
...java/io/trino/plugin/iceberg/catalog/rest/TestIcebergTrinoRestCatalogConnectorSmokeTest.java Outdated Show resolved Hide resolved
...java/io/trino/plugin/iceberg/catalog/rest/TestIcebergTrinoRestCatalogConnectorSmokeTest.java Outdated Show resolved Hide resolved
@sftwrdvlpr sftwrdvlpr force-pushed the issue-22916 branch 2 times, most recently from 7b67e36 to b8b4cbf Compare October 8, 2024 07:32
@sftwrdvlpr sftwrdvlpr requested a review from ebyhr October 8, 2024 07:34
@sftwrdvlpr
Copy link
Contributor Author

@ebyhr is there any way to re-run failed checks without pushing changes to the branch?

@ebyhr
Copy link
Member

ebyhr commented Oct 8, 2024

@sftwrdvlpr Only maintainers can do that. Let me know if you want to rerun specific jobs in this PR.

@sftwrdvlpr sftwrdvlpr force-pushed the issue-22916 branch 2 times, most recently from 4fcaf99 to 3b2657a Compare October 9, 2024 00:40
@sftwrdvlpr sftwrdvlpr requested a review from ebyhr October 9, 2024 02:23
@ebyhr
Copy link
Member

ebyhr commented Oct 15, 2024

@sftwrdvlpr Could you rebase on master to resolve conflicts?

@sftwrdvlpr
Copy link
Contributor Author

sftwrdvlpr commented Oct 16, 2024 •
edited
Loading

@ebyhr could you please tell me about parent namespace concept?

@trinodb trinodb deleted a comment from cla-bot bot Oct 16, 2024
@trinodb trinodb deleted a comment from cla-bot bot Oct 16, 2024
@trinodb trinodb deleted a comment from cla-bot bot Oct 16, 2024
@trinodb trinodb deleted a comment from cla-bot bot Oct 16, 2024
@trinodb trinodb deleted a comment from cla-bot bot Oct 16, 2024
@ebyhr ebyhr changed the title Nested namespaces support for Rest catalog Add support for nested namespaces in Iceberg REST catalog Oct 16, 2024
anusudarsan
anusudarsan reviewed Oct 16, 2024
View reviewed changes
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
@@ -13,6 +13,7 @@
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some description to the commit message giving some implementation details, config usage etc.

@ebyhr ebyhr merged commit 31a060c into trinodb:master Oct 21, 2024
2 of 12 checks passed
@github-actions github-actions bot added this to the 463 milestone Oct 21, 2024
@mosabua mosabua mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayankvadariya mayankvadariya mayankvadariya left review comments

@anusudarsan anusudarsan anusudarsan left review comments

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed iceberg Iceberg connector
Milestone
463
Development

Successfully merging this pull request may close these issues.

Support nested namespaces for Iceberg REST catalog
4 participants
@sftwrdvlpr @ebyhr @anusudarsan @mayankvadariya