Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forward testing] Test JDK 24-ea build 19 (2024/10/10) #23501

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Forward testing] Test JDK 24-ea build 19 (2024/10/10) #23501

wants to merge 1 commit into from
+18 −20

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 19, 2024 •
edited
Loading

Fixes #23498

https://jdk.java.net/24/

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2024
@wendigo wendigo mentioned this pull request Sep 19, 2024
Open
8 tasks
@wendigo wendigo force-pushed the serafin/jdk24-ea branch 6 times, most recently from 9f6711d to 5fc99f9 Compare September 19, 2024 12:01
@wendigo wendigo changed the title [WIP] Test JDK 24-ea [Forward testing] Test JDK 24-ea Sep 19, 2024
mosabua
mosabua approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go and run for testing..

Note to others ... we wont merge this ...

pom.xml Outdated Show resolved Hide resolved
@wendigo wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from a834a55 to b97f836 Compare September 23, 2024 13:47
@wendigo wendigo changed the title [Forward testing] Test JDK 24-ea [Forward testing] Test JDK 24-ea build 16 (2024/9/19) Sep 23, 2024
@wendigo wendigo changed the title [Forward testing] Test JDK 24-ea build 16 (2024/9/19) [DONOTMERGE] [Forward testing] Test JDK 24-ea build 16 (2024/9/19) Sep 23, 2024
mosabua
mosabua requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to adjust this over time .. so not ready to merge for a while .. but important for updating and monitoring progress towards 24

@wendigo wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from 6492488 to 12a1333 Compare September 30, 2024 19:29
@wendigo wendigo changed the title [DONOTMERGE] [Forward testing] Test JDK 24-ea build 16 (2024/9/19) [DONOTMERGE] [Forward testing] Test JDK 24-ea build 17 (2024/9/19) Oct 1, 2024
@wendigo wendigo changed the title [DONOTMERGE] [Forward testing] Test JDK 24-ea build 17 (2024/9/19) [DONOTMERGE] [Forward testing] Test JDK 24-ea build 18 (2024/10/04) Oct 7, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Oct 7, 2024

Since the ASM update has landed. Now this doesn't require any code/infrastructure changes

losipiuk
losipiuk approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark as draft

@losipiuk losipiuk marked this pull request as draft October 7, 2024 08:46
@wendigo
Copy link
Contributor Author

wendigo commented Oct 7, 2024

@losipiuk draft doesn't run CI, right?

@martint
Copy link
Member

martint commented Oct 7, 2024

draft doesn't run CI, right?

It didn’t when the feature launched, but it does now.

@wendigo wendigo changed the title [DONOTMERGE] [Forward testing] Test JDK 24-ea build 18 (2024/10/04) [Forward testing] Test JDK 24-ea build 19 (2024/10/10) Oct 11, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Oct 15, 2024

More JDK 24 goodies: https://openjdk.org/jeps/485

@wendigo
Copy link
Contributor Author

wendigo commented Oct 15, 2024

And https://openjdk.org/jeps/484 :)

@wendigo
Copy link
Contributor Author

wendigo commented Oct 18, 2024

Updated to beta 20

@wendigo wendigo force-pushed the serafin/jdk24-ea branch 3 times, most recently from 35ab167 to a23c7d9 Compare October 22, 2024 12:33
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Oct 22, 2024
@wendigo wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from f214df6 to 8fa6213 Compare October 22, 2024 13:01
martint
martint reviewed Oct 24, 2024
View reviewed changes
client/trino-jdbc/src/test/java/io/trino/jdbc/BaseTestJdbcResultSet.java Outdated
@@ -465,12 +465,12 @@ public void testTimeWithTimeZone()
Time.valueOf(
LocalTime.of(15, 39, 7)).getTime() /* 15:39:07 = 00:39:07 - +01:00 shift + Bahia_Banderas's shift (-8) (modulo 24h which we "un-modulo" below) */
- DAYS.toMillis(1) /* because we use currently 'shifted' representation, not possible to create just using LocalTime */
+ HOURS.toMillis(1) /* because there was offset shift on 1970-01-01 in America/Bahia_Banderas */);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Political timezones don't affect time w/ tz. These comments are no longer applicable.

core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java Outdated
@@ -101,7 +101,7 @@ public void testCurrentDateTimezone()
millis += timeIncrement) {
Instant instant = Instant.ofEpochMilli(millis);
assertCurrentDateAtInstant(kievTimeZoneKey, instant);
assertCurrentDateAtInstant(bahiaBanderasTimeZoneKey, instant);
assertCurrentDateAtInstant(bajaSurTimeZoneKey, instant);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sure what this test buys us. I would just drop it.

core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java Outdated
@@ -397,7 +397,7 @@ public void testLastDayOfMonth()
assertThat(assertions.function("last_day_of_month", "TIMESTAMP '2001-08-22 03:04:05.321 +07:09'"))
.matches("DATE '2001-08-31'");

ImmutableList.of("+05:45", "+00:00", "-05:45", "Asia/Tokyo", "Europe/London", "America/Los_Angeles", "America/Bahia_Banderas").forEach(timeZone -> {
ImmutableList.of("+05:45", "+00:00", "-05:45", "Asia/Tokyo", "Europe/London", "America/Los_Angeles", "Mexico/BajaSur").forEach(timeZone -> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint left review comments

@mosabua mosabua mosabua requested changes

@losipiuk losipiuk losipiuk approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use and require Java 24
4 participants
@wendigo @martint @mosabua @losipiuk