Add eslint-plugin-html to lint JS in HTML files #37186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #36915
Description
This PR introduces the use of
eslint-plugin-html
to lint JavaScript within HTML files in<script>
s.It seemed to be the best and recommended tool to do it. Feel free to double check if this choice is valid :)
Some extra info:
/site/.eslintrc.json
have been reused (thanks @GeoSot for pointing out these rules)"no-console": "off"
has been added since it is useful for debugging these standalone pages that never will be in productionI wasn't a big fan of
--ext .html,.js
as I'd prefer to target only the HTML files we want to parse but it seems that there's no other way to do it:Source: https://www.npmjs.com/package/eslint-plugin-html#troubleshooting